Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap PyTest version to avoid failures #772

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Cap PyTest version to avoid failures #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b5e76
Cap PyTest version to avoid failures
Morendil Nov 16, 2018
d987557
Bump version
Morendil Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Changelog

### 24.8.1 [#772](https://github.com/openfisca/openfisca-core/pull/772)

- Limits the range of PyTest versions to < 4.0 to avoid CI crashes caused by 4.0.

## 24.8.0 [#765](https://github.com/openfisca/openfisca-core/pull/765)

- Add called parameters to Web API `/trace` endpoint
- Adds called parameters to Web API `/trace` endpoint
Copy link
Member

@fpagnoux fpagnoux Nov 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Like for commit messages, I think using the imperative mood is preferable for changelog messages. Looking down at the previous versions, there seems to be a trend to use the indicative, but that's pretty recent, and I don't think we should go that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency with nearby parts of the Changelog, which used the indicative (24.7.0, 24.6.6, I overlooked 24.6.8). You're right, it's been inconsistent lately (even in some cases inconsistent in the same version).

- For a calculated variable, add `parameters` item next to `dependencies` in `/trace` response
- For example:
```JSON
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@
'autopep8 == 1.4.0',
'flake8 >= 3.5.0, < 3.6.0',
'pycodestyle >= 2.3.0, < 2.4.0', # To avoid incompatibility with flake8
'pytest',
'pytest < 4.0',
'openfisca-country-template >= 3.4.0, < 4.0.0',
'openfisca-extension-template >= 1.1.3, < 2.0.0',
] + api_requirements

setup(
name = 'OpenFisca-Core',
version = '24.8.0',
version = '24.8.1',
author = 'OpenFisca Team',
author_email = 'contact@openfisca.org',
classifiers = [
Expand Down