feat: #2425 - added "all products to be completed" item (in user page) #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(in user page) New files: * `paged_to_be_completed_product_query.dart`: Back-end paged query for all "to-be-completed" products. * `tmp_to_be_completed_query_configuration.dart`: Query Configuration for all to-be-completed products. Deleted files: * `contributor_product_query.dart` * `informer_product_query.dart` * `photographer_product_query.dart` * `to_be_completed_product_query.dart` Impacted files * `app_en.arb`: 1 label slightly modified, 1 added label. * `app_fr.arb`: 1 label slightly modified, 1 added label. * `paged_user_product_query.dart`: refactored around `UserProductSearchQueryConfiguration`. * `product_list.dart`: added a new list - all products to be completed (not just the user's). * `product_list_page.dart`: refactored. * `product_query_page_helper.dart`: refactored. * `user_preferences_account.dart`: added an item for "all to-be-completed"; refactored.
Codecov Report
@@ Coverage Diff @@
## develop #2441 +/- ##
==========================================
- Coverage 8.86% 7.52% -1.34%
==========================================
Files 161 201 +40
Lines 6623 9763 +3140
==========================================
+ Hits 587 735 +148
- Misses 6036 9028 +2992
Continue to review full report at Codecov.
|
Impacted files * `paged_to_be_completed_product_query.dart` * `user_preferences_account.dart`
M123-dev
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
The code looks good, thanks @monsieurtanuki thus approving.
But I don't think the profile is the right place for this page any idea @teolemon
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
paged_to_be_completed_product_query.dart: Back-end paged query for all "to-be-completed" products.tmp_to_be_completed_query_configuration.dart: Query Configuration for all to-be-completed products.Deleted files:
contributor_product_query.dartinformer_product_query.dartphotographer_product_query.dartto_be_completed_product_query.dartImpacted files
app_en.arb: 1 label slightly modified, 1 added label.app_fr.arb: 1 label slightly modified, 1 added label.paged_user_product_query.dart: refactored aroundUserProductSearchQueryConfiguration.product_list.dart: added a new list - all products to be completed (not just the user's).product_list_page.dart: refactored.product_query_page_helper.dart: refactored.user_preferences_account.dart: added an item for "all to-be-completed"; refactored.What
Screenshot
Fixes bug(s)