Show the Products Edited by the user #2315

teolemon · 2022-06-19T07:50:22Z

What

In V1, we used to have links to Products Edited / Photographed / Added by the user
Bring those link back in the profile page
V1 bug (and linked PR): Create a list of products added by the user openfoodfacts-androidapp#194

Mockup

M123-dev · 2022-06-19T09:55:02Z

@teolemon links or pages on the app

teolemon · 2022-06-19T10:07:26Z

Native pages of products in the app, so that people can go back to those products, and work on them

teolemon · 2022-06-19T11:46:25Z

Also related to Introduce a Products to be completed page, as fan service to power users. #1074 and the user complaining he lost his pasttime in User-reported issues in bulk #2318

…le screen New files: * `contributor_product_query.dart`: User Product Search, in "contributor" mode. * `informer_product_query.dart`: User Product Search, in "informer" mode. * `paged_search_product_query.dart`: Back-end paged queries around search. * `paged_user_product_query.dart`: Back-end paged queries around User. * `photographer_product_query.dart`: User Product Search, in "photographer" mode. * `to_be_completed_product_query.dart`: User Product Search, in "to be completed" mode. Impacted files: * `category_product_query.dart`: refactored with new class `PagedSearchProductQuery` * `keywords_product_query.dart`: refactored with new class `PagedSearchProductQuery` * `paged_product_query.dart`: now limited to page management * `product_list.dart`: added `enum`s and constructors around user queries * `product_list_page.dart`: added cases for the new 4 product list types * `product_query_page_helper.dart`: added cases for the new 4 product list types * `user_preferences_account.dart`

) New files: * `contributor_product_query.dart`: User Product Search, in "contributor" mode. * `informer_product_query.dart`: User Product Search, in "informer" mode. * `paged_search_product_query.dart`: Back-end paged queries around search. * `paged_user_product_query.dart`: Back-end paged queries around User. * `photographer_product_query.dart`: User Product Search, in "photographer" mode. * `to_be_completed_product_query.dart`: User Product Search, in "to be completed" mode. Impacted files: * `category_product_query.dart`: refactored with new class `PagedSearchProductQuery` * `keywords_product_query.dart`: refactored with new class `PagedSearchProductQuery` * `paged_product_query.dart`: now limited to page management * `product_list.dart`: added `enum`s and constructors around user queries * `product_list_page.dart`: added cases for the new 4 product list types * `product_query_page_helper.dart`: added cases for the new 4 product list types * `user_preferences_account.dart`

monsieurtanuki · 2022-06-20T07:21:10Z

The problem is that the queries are not verbose enough: we have limited data about the products => help needed!

cf. #2321

@teolemon Any suggestion?

teolemon · 2022-06-20T07:24:52Z

What do you mean ? I'm not quite sure. You mean Eco-Score and Nutri-Score are not displayed ?

teolemon · 2022-06-20T07:25:31Z

http://world.openfoodfacts.org/photographer/teolemon/state/to-be-completed.json?fields=XXX

Impacted file: * `paged_user_product_query.dart`

…localized Impacted files: * `app_en.arb`: added a title for each of the 4 user queries * `app_fr.arb`: added a title for each of the 4 user queries * `paged_user_product_query.dart`: added smoothie fields to user queries * `product_list_page.dart`: refactored * `product_query_page_helper.dart`: refactored by removing useless code * `user_preferences_account.dart`: refactored and translated

) Impacted files: * `app_en.arb`: added a title for each of the 4 user queries * `app_fr.arb`: added a title for each of the 4 user queries * `paged_user_product_query.dart`: added smoothie fields to user queries * `product_list_page.dart`: refactored * `product_query_page_helper.dart`: refactored by removing useless code * `user_preferences_account.dart`: refactored and translated

monsieurtanuki · 2022-06-29T12:23:38Z

Needs minor refactoring using the brand new off-dart 1.20.0 methods from openfoodfacts/openfoodfacts-dart#488.

monsieurtanuki · 2022-06-30T08:23:40Z

@teolemon @stephanegigandet Actually there's a little bug I've just discovered, on the server side.

With the latest version of off-dart, we also put the language in the query. Which is a good idea, isn't it?

It works well for the first 3 queries (contributor, informer, photographer).
But for the last one ("to be completed") the server translates the URL, and that fails.

When I add no language to https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json, everything is fine
When I put the language
- https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json?lc=fr
- get translated into
- https://world.openfoodfacts.org/informateur/monsieurtanuki/etat/a-completer.json
- and instead of json results I get this response:

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="/informateur/monsieurtanuki/etat/a-completer.json">here</a>.</p>
<hr>
<address>Apache/2.4.25 (Debian) Server at world.openfoodfacts.org Port 80</address>
</body></html>

What shall we do? Should we handle that in off-dart? Is that a bad redirection code on the server side?

teolemon · 2022-07-04T13:28:21Z

@monsieurtanuki the best solution I have right now is using the States taxonomy: https://static.openfoodfacts.org/data/taxonomies/states.json

teolemon · 2022-07-04T13:29:17Z

Otherwise, the tags are stored in https://github.com/openfoodfacts/openfoodfacts-server/blob/e32683cdfdf05b9e83667efaa8494c0dd17e65b4/po/tags/fr.po and not in a structured form

monsieurtanuki · 2022-07-05T06:31:38Z

@teolemon What you suggest wouldn't be very elegant:

we start from the "standard" url https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json
we translate informer (we need the translations)
we translate state (we need the translations)
we translate to-be-completed thanks to https://static.openfoodfacts.org/data/taxonomies/states.json that only translates in 22 languages, and for that we need to download the states.json file for each query
in addition to that we must change the country too because without that it doesn't work - though that get a little awkward here - "list the products I've changed from this country"

Actually, the keys seem to be

setting the correct country (which was not supported so far as it didn't seem appropriate)
not setting the language (or translate it "your way")

Another problem is the discrepancies in the number of "to-be-completed" products depending on the countries.

count	url
39	https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json
4	https://it.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json
38	https://fr.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json
38	https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json?cc=fr
(fails)	https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json?lc=fr
(fails)	https://world.openfoodfacts.org/informer/monsieurtanuki/state/to-be-completed.json?lc=fr&cc=fr

What I can do for the moment is unset the language value for this specific query in Smoothie: we'll have the max number of results, and I hope not having the language as a parameter won't have side-effects.

monsieurtanuki · 2022-07-05T09:03:53Z

The problem is that we cannot really force the language to null:

if we put null as language parameter it is not considered as "we want no value" but "please put the default value". We can fix that in Smoothie by setting the default value to null
but then we have another problem: all the "in-languages" fields make the app crash as there's no language

stephanegigandet · 2022-07-06T08:14:37Z

@monsieurtanuki I'm fixing the redirect server side.

But those kinds of URLs (adding .json to web site URLs to get the products) should not be used in the app, they are mostly for debugging purposes.

We should use the search API instead, and there won't be redirects.

e.g. https://world.openfoodfacts.org/api/v2/search?informers_tags=monsieurtanuki&states_tags=en:to-be-completed&lc=fr&cc=fr

stephanegigandet · 2022-07-06T08:20:58Z

Server side fix: openfoodfacts/openfoodfacts-server#7019

monsieurtanuki · 2022-07-06T10:54:08Z

Thank you @stephanegigandet!
I'm fixing the URL according to your specs on the off-dart side too.

stephanegigandet · 2022-07-06T11:37:50Z

Great, thank you!

…h not English language Deleted file: * `tmp_to_be_completed_query_configuration.dart`: now included (and fixed) in off-dart 1.21.0 Impacted files: * `paged_to_be_completed_product_query.dart`: now uses off-dart 1.21.0 query instead of tmp * `Podfile.lock`: wtf * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart version to 1.21.0

… language (#2521) Deleted file: * `tmp_to_be_completed_query_configuration.dart`: now included (and fixed) in off-dart 1.21.0 Impacted files: * `paged_to_be_completed_product_query.dart`: now uses off-dart 1.21.0 query instead of tmp * `Podfile.lock`: wtf * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart version to 1.21.0

M123-dev changed the title ~~Add the links to Products Edited by the user~~ Show the Products Edited by the user Jun 19, 2022

teolemon added 👥 User management Account login, signup, signout ✏️ Contribution labels Jun 19, 2022

teolemon added this to 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 19, 2022

teolemon moved this to To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 19, 2022

monsieurtanuki self-assigned this Jun 19, 2022

monsieurtanuki mentioned this issue Jun 19, 2022

feat: #2315 - added 4 user-related searches in the profile screen #2321

Merged

monsieurtanuki closed this as completed in #2321 Jun 19, 2022

Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 19, 2022

monsieurtanuki reopened this Jun 20, 2022

monsieurtanuki mentioned this issue Jun 20, 2022

Move the "user search" query method from smoothie openfoodfacts/openfoodfacts-dart#488

Closed

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jun 20, 2022

feat: openfoodfacts#2315 - added smoothie fields to user queries

a6a7796

Impacted file: * `paged_user_product_query.dart`

monsieurtanuki mentioned this issue Jun 20, 2022

feat: #2315 - added smoothie fields to user queries and localized #2332

Merged

monsieurtanuki closed this as completed in #2332 Jun 20, 2022

monsieurtanuki mentioned this issue Jun 26, 2022

feat: #488 - new user-related queries openfoodfacts/openfoodfacts-dart#499

Merged

monsieurtanuki reopened this Jun 29, 2022

monsieurtanuki mentioned this issue Jun 30, 2022

feat: #2425 - added "all products to be completed" item (in user page) #2441

Merged

monsieurtanuki added the 🐛 bug Something isn't working label Jul 1, 2022

teolemon mentioned this issue Jul 1, 2022

301 response makes it difficult to implement a feature openfoodfacts/openfoodfacts-server#6993

Closed

stephanegigandet mentioned this issue Jul 6, 2022

fix: add missing subdomain to redirect url #6993 openfoodfacts/openfoodfacts-server#7019

Merged

monsieurtanuki mentioned this issue Jul 6, 2022

fix: toBeCompleted - fixed uri and parameters for to be completed and user queries openfoodfacts/openfoodfacts-dart#506

Merged

monsieurtanuki mentioned this issue Jul 6, 2022

fix: #2315 - "to be completed" queries now work even with not English language #2521

Merged

monsieurtanuki closed this as completed in #2521 Jul 6, 2022

github-actions bot mentioned this issue Aug 10, 2022

chore(develop): release 3.7.0 #2735

Merged

github-actions bot mentioned this issue Sep 6, 2022

chore(develop): release 3.14.0 #2951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show the Products Edited by the user #2315

Show the Products Edited by the user #2315

teolemon commented Jun 19, 2022 •

edited

Loading

M123-dev commented Jun 19, 2022

teolemon commented Jun 19, 2022

teolemon commented Jun 19, 2022 •

edited

Loading

monsieurtanuki commented Jun 20, 2022

teolemon commented Jun 20, 2022

teolemon commented Jun 20, 2022 •

edited

Loading

monsieurtanuki commented Jun 29, 2022

monsieurtanuki commented Jun 30, 2022

teolemon commented Jul 4, 2022

teolemon commented Jul 4, 2022

monsieurtanuki commented Jul 5, 2022

monsieurtanuki commented Jul 5, 2022

stephanegigandet commented Jul 6, 2022

stephanegigandet commented Jul 6, 2022

monsieurtanuki commented Jul 6, 2022

stephanegigandet commented Jul 6, 2022

Show the Products Edited by the user #2315

Show the Products Edited by the user #2315

Comments

teolemon commented Jun 19, 2022 • edited Loading

What

Mockup

M123-dev commented Jun 19, 2022

teolemon commented Jun 19, 2022

teolemon commented Jun 19, 2022 • edited Loading

monsieurtanuki commented Jun 20, 2022

teolemon commented Jun 20, 2022

teolemon commented Jun 20, 2022 • edited Loading

monsieurtanuki commented Jun 29, 2022

monsieurtanuki commented Jun 30, 2022

teolemon commented Jul 4, 2022

teolemon commented Jul 4, 2022

monsieurtanuki commented Jul 5, 2022

monsieurtanuki commented Jul 5, 2022

stephanegigandet commented Jul 6, 2022

stephanegigandet commented Jul 6, 2022

monsieurtanuki commented Jul 6, 2022

stephanegigandet commented Jul 6, 2022

teolemon commented Jun 19, 2022 •

edited

Loading

teolemon commented Jun 19, 2022 •

edited

Loading

teolemon commented Jun 20, 2022 •

edited

Loading