Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power edit mode that concatenates all the editable things for faster contribution #2337

Closed
1 task
Tracked by #2318
teolemon opened this issue Jun 20, 2022 · 6 comments · Fixed by #2617
Closed
1 task
Tracked by #2318
Assignees
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1

Comments

@teolemon
Copy link
Member

teolemon commented Jun 20, 2022

User 1: New viersion of this app is nightmare. It is impossible to use, it has bad ux design, it is slow. Who really get the idea to break down user interface? Luckily I can choose old version on F-Droid.
User 2: However, an advanced mode could be considered, in order to correct and add information on a page with more options. Currently the addition of the origin and country of manufacture is no longer possible?

Proposed solution

  • Add power edit mode that concatenates all the editable things for faster contribution

Part of

@monsieurtanuki
Copy link
Contributor

@teolemon If we're lucky both unhappy users would be kind enough to help us make a better app: I hope we can contact them.

@teolemon
Copy link
Member Author

I'm waiting for more feedback, but I believe they're touching real. I have this experience as a power user too, so I'd be user 3. It's harder to understand what to do on an existing product, clicking on Edit on the old app allowed to have a bird's eye view of all fields.

@teolemon teolemon added ✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Jun 20, 2022
@monsieurtanuki
Copy link
Contributor

I think there's nothing that would prevent us from putting all the SimpleInputPages into one if needed (category, labels, store for the moment), possibly with a collapse/expand effect. Would that be good?

@teolemon
Copy link
Member Author

teolemon commented Jul 2, 2022

Here's a mockup of editing mode (I realized I didn't have one).

  • I've added
    • a Full edit mode button
    • Inline image prompts + Miniature of images if here
    • A way to display a scanneable barcode of the product

image

@monsieurtanuki monsieurtanuki self-assigned this Jul 18, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon I'm about to PR.

We have 6 "simple" edit pages that can be grouped into just one. The other edit pages are too complex (pictures and possibly different languages).
If we replace the 6 items into a "power user" item the "edit product" page is much more compact. Yeah that's it, no need to scroll down, and I think we could probably get rid of the "single item" pages:
Capture d’écran 2022-07-18 à 12 28 19

This is what the "power user" page currently looks like - cosmetic changes are definitely needed:
Capture d’écran 2022-07-18 à 12 34 26

@teolemon
Copy link
Member Author

  • Sorry for my lack of responsiveness, thinking hard on the future of Open Products Facts at the moment :-)
  • I think we should keep the option for granular editing, especially from knowledge panels, and because I've also had a lot of 'The power view of V1 is overwhelming'
  • Agreed we'll need some redesign, eg. copying the icons we added for instance in the edit view index, adding homogeneous left padding, and homogeneous vertical padding before fields

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 18, 2022
New file:
* `simple_input_widget.dart`: Simple input widget: we have a list of terms, we add, we remove.

Impacted files
* `edit_product_page.dart`: added an item that includes 6 simple items;
* `simple_input_page.dart`: now manages multiple items; now using new widget `SimpleInputWidget
* `simple_input_page_helpers.dart`: refactored for a better "multiple changes" management
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 22, 2022
…nsistency

Impacted file:
* `simple_input_page.dart`: now uses `SmoothCard` instead of `Card` for consistency
monsieurtanuki added a commit that referenced this issue Jul 22, 2022
New file:
* `simple_input_widget.dart`: Simple input widget: we have a list of terms, we add, we remove.

Impacted files
* `edit_product_page.dart`: added an item that includes 6 simple items;
* `simple_input_page.dart`: now manages multiple items; now using new widget `SimpleInputWidget
* `simple_input_page_helpers.dart`: refactored for a better "multiple changes" management
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1
Development

Successfully merging a pull request may close this issue.

2 participants