feat: #2337 - additional "power user" product edit page #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `simple_input_widget.dart`: Simple input widget: we have a list of terms, we add, we remove. Impacted files * `edit_product_page.dart`: added an item that includes 6 simple items; * `simple_input_page.dart`: now manages multiple items; now using new widget `SimpleInputWidget * `simple_input_page_helpers.dart`: refactored for a better "multiple changes" management
teolemon
added
the
✏️ Editing
|
@monsieurtanuki Do the classic edit view get the icon as a result ? |
@teolemon If you mean "does the edit store page display a card with 'Stores' as a title and the icon as a leading icon?", that's correct. Of course in the "single edit" pages, we could get rid of:
Would that look better to you? |
M123-dev
approved these changes
Jul 21, 2022
| padding: i == 0 | ||
| ? EdgeInsets.zero | ||
| : const EdgeInsets.only(top: LARGE_SPACE), | ||
| child: Card( |
…nsistency Impacted file: * `simple_input_page.dart`: now uses `SmoothCard` instead of `Card` for consistency
Codecov Report
@@ Coverage Diff @@
## develop #2617 +/- ##
==========================================
- Coverage 8.86% 7.43% -1.43%
==========================================
Files 161 213 +52
Lines 6623 10278 +3655
==========================================
+ Hits 587 764 +177
- Misses 6036 9514 +3478
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Thank you @M123-dev for the review, I've changed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file:
simple_input_widget.dart: Simple input widget: we have a list of terms, we add, we remove.Impacted files
edit_product_page.dart: added an item that includes 6 simple items;simple_input_page.dart: now manages multiple items; now using new widget `SimpleInputWidgetsimple_input_page_helpers.dart: refactored for a better "multiple changes" managementWhat
Screenshot
Fixes bug(s)