-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: miniature of ingredients blocks the text #2964
fix: miniature of ingredients blocks the text #2964
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2964 +/- ##
==========================================
- Coverage 6.94% 6.63% -0.32%
==========================================
Files 229 236 +7
Lines 11155 11731 +576
==========================================
+ Hits 775 778 +3
- Misses 10380 10953 +573
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M123-dev!
Not very convinced: of course it probably solves the issue (a screenshot would be nice), but the Image is therefore probably a bit little.
Possible improvement: use the RRect like in the product items in lists.
Not sure if it's much bigger, but at least it's vaguely consistent with the rest of the app.
SizedBox( | ||
height: MINIMUM_TOUCH_SIZE, | ||
width: MINIMUM_TOUCH_SIZE, | ||
child: Image.file(image, fit: BoxFit.cover), | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not that big. Probably ridiculous for images in height.
Thanks for the review @monsieurtanuki, I added the RRect and changed the size back to 50 as this will be changed anyways by #2843 |
What