Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert https://github.com/openfoodfacts/smooth-app/pull/3666 #3701

Closed
teolemon opened this issue Feb 13, 2023 · 3 comments · Fixed by #3702
Closed

Revert https://github.com/openfoodfacts/smooth-app/pull/3666 #3701

teolemon opened this issue Feb 13, 2023 · 3 comments · Fixed by #3702
Assignees
Labels
🐛 bug Something isn't working

Comments

@teolemon
Copy link
Member

teolemon commented Feb 13, 2023

What

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Feb 13, 2023

To give some context: the revamp of the scan is very important topic (probably the most important topic of the app), so we should not rush it just because the Flutter upgrade broke the scanner.

Reverting the upgrade to Flutter so that we have a working app (without the bug #3670), on which we can add and deploy fixes and improvements (such as #3663), will give us time to explore solutions (such as #3694 proposed by @monsieurtanuki), to make the right choices and to create a great scanning experience.

@monsieurtanuki
Copy link
Contributor

I've just PR'ed #3702.

The priority now should probably be to fix the MLKit part so that it works on flutter 3.7.

@teolemon
Copy link
Member Author

Thank you very much @monsieurtanuki 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Development

Successfully merging a pull request may close this issue.

5 participants