Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" #3702

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

monsieurtanuki
Copy link
Contributor

This reverts commit ad46236.

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner February 13, 2023 11:40
@github-actions github-actions bot added dependencies 🍎 iOS iOS specific issues or PRs MacOS 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🧪 Tests 🤳 ZXing labels Feb 13, 2023
@monsieurtanuki monsieurtanuki changed the title Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" chore: Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" Feb 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3702 (0c574e9) into develop (f2ede98) will increase coverage by 0.97%.
The diff coverage is 43.47%.

@@             Coverage Diff             @@
##           develop    #3702      +/-   ##
===========================================
+ Coverage     9.34%   10.32%   +0.97%     
===========================================
  Files          272      272              
  Lines        13722    13734      +12     
===========================================
+ Hits          1283     1418     +135     
+ Misses       12439    12316     -123     
Impacted Files Coverage Δ
...ooth_app/lib/background/background_task_badge.dart 8.33% <0.00%> (-0.76%) ⬇️
...ackages/smooth_app/lib/helpers/network_config.dart 0.00% <0.00%> (ø)
...owledge_panels/knowledge_panel_world_map_card.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.00% <0.00%> (ø)
...p/lib/pages/product/common/product_query_page.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/scan/camera_scan_page.dart 0.43% <0.00%> (-0.01%) ⬇️
...ib/pages/preferences/account_deletion_webview.dart 91.30% <90.90%> (+91.30%) ⬆️
...lib/query/paged_to_be_completed_product_query.dart 3.84% <0.00%> (+3.84%) ⬆️
..._app/lib/data_models/user_management_provider.dart 4.87% <0.00%> (+4.87%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@monsieurtanuki monsieurtanuki merged commit dd0d548 into openfoodfacts:develop Feb 14, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @stephanegigandet for the review!
I guess #3642 should probably be reverted too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🍎 iOS iOS specific issues or PRs MacOS 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🧪 Tests 🤳 ZXing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert https://github.com/openfoodfacts/smooth-app/pull/3666
3 participants