Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If the latest barcode is removed from the carousel, it should be scannable again #2746

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 8, 2022

If I scan a barcode, then remove it, it should be scannable again.
Presently, nothing happens.

Part of #2741

@g123k g123k added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Aug 8, 2022
@g123k g123k self-assigned this Aug 8, 2022
@g123k g123k requested a review from a team as a code owner August 8, 2022 08:27
@@ -1,4 +1,5 @@
import 'dart:async';

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by dartfmt

@g123k
Copy link
Collaborator Author

g123k commented Aug 8, 2022

For tests failing, here is the story: #2747

@M123-dev
Copy link
Member

M123-dev commented Aug 8, 2022

Updated this PR tests working again

@teolemon
Copy link
Member

teolemon commented Aug 8, 2022

thanks @g123k
merging and deploying to internal

@teolemon teolemon merged commit ae75c50 into openfoodfacts:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants