We have a BIG scan issue #2741
Assignees
Labels
Milestone
Comments
teolemon
added
🎯 P0
🤳🥫 Scan
teolemon
moved this to To discuss and validate
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
|
There is an issue I’m currently working on: a product added, then removed, can not be scanned anymore. so we have to be really careful when we talk about the scan. |
|
@teolemon Any news from the iOS users? For the permission's screen, do you know where Quentin took the illustrations for the onboarding? |
VaiTon
moved this from To discuss and validate
to In Progress
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
|
My suggestions on the topic as a back-seat driver, ordered by decreasing relevancy:
|
|
For the isolate thing, we only have 1 isolate running. |
|
You mean that beside the isolate currently running, there's at maximum another one pending, am I right? |
|
No there is just one Isolate, but I thought you meant that each photo = one Isolate, which is not the case. The data is only sent when the decoding happens, so no worry about that. But it seems that the issue is not about the Isolate itself, but more related to the camera. Unless I have a device with the issue, I can’t say more, because users are only stating « it doesn’t work ». Really helpful, thanks >_< |
I need to have a look at your code then, there's something I don't understand.
Indeed, that's why I ranked the specific camera scan page/widget as more important.
Unfortunately that's a common pattern for users :) |
|
@g123k As I said, I don't think the That said, I would like you to run performance tests (when you have time) around the types of barcodes. BarcodeFormat.ean8, // Retail, ok
BarcodeFormat.ean13, // Retail, ok
BarcodeFormat.upca, // Retail, ok
BarcodeFormat.upce, // Retail, ok
BarcodeFormat.code39, // Automotive and Defense, probably irrelevant
BarcodeFormat.code93, // Retail, Manufacturing and Logistics, not sure
BarcodeFormat.code128, // Supply Chain, probably irrelevant
BarcodeFormat.itf, // Packaging, not sure
BarcodeFormat.codabar, // Logistics, Healthcare and Education, probably irrelevantI also think that your computation of average time is slightly flawed, because you consider both actual barcode scan operations (which is good) AND aborted operations (that failed because another operation is already running) (which is not relevant). |
|
"Kann kein neues Produkt hinzufügen, wenn ich es einscanne." |
Translated: I can't add new products when I scan them |
|
Once again, the sentence by itself doesn't help us. That's the real issue we have… with this issue. @teolemon Any feedback from the iOS users you emailed? |
|
I lost the draft email we made during the call. I just did this https://calendly.com/openfoodfacts/debugging-the-scan-on-open-food-facts-together @g123k |
|
Just a quick update: this morning we were finally able to see the problem in a real device with @teolemon. The camera is working well, but the scan doesn’t seem to work. I will receive the faulty device |
|
Good luck @g123k! |
|
Camera crash log (smoothie downloaded today from play store on Android 21). The onboarding is fine, but the app crashes when I land on the camera/scan page: |
|
Which device was it? |
|
It's my canary device: 2015 Samsung Galaxy Core Prime. |
|
Ok. Please keep me posted. |
|
That's what I'm doing, after the crash on the release version. |
|
I have to go now. |
|
Good news: I've finally received the OnePlus phone and I can reproduce the issue. Testing the example from the Flutter library (google_mlkit_barcode_scanning) doesn't scan. … But after trying the Google sample app, I'm able to detect barcodes with MLKit. |
|
Maybe we have different ml kit version either a older maybe buggy one or the native app uses the not bundled release |
|
Unfortunately, that's the same library version on both apps. So two options:
|
|
I didn't have time this morning to take a better look at the problem. But I think our current implementation is broken, by having 2 native plugins, as it forces us to continuously send messages between the Dart code and the native one. If I sum, here is the current flow: I was wondering, if we shouldn't create our own plugin (= native) handling both the camera and MLKit: Instead of doing Dart <-> camera preview <-> Native and Dart <-> camera data <-> Native, we will have : What would you think about this kind of solution? |
|
@g123k this plan makes complete sense, doing it like that would also save use the hassle with the isolate as native code by default runs on another thread. The only thing which only you can give answer to is if it justifies the time needed to get this to work. |
|
@g123k The main question is: are you fortunate enough to have a device on which the camera/scan currently crashes? |
|
For scan issues, after spending hours trying to understand the root cause of the issue, I have to surrender… 😔
This is the cause of MLKit being unable to decode any barcode
As we've already discussed, the solution is to use an all-in-one library, but we have to deploy a fixed version of the app ASAP. I will then develop an "alternative" mode for the scan, where instead of passing the camera feed, it will be a File. Also the app will use this "alternative" mode by default on OnePlus devices + can be changed via the settings. |
|
Just happened on my Pixel 6. I Can't scan anymore |
|
@g123k reverting to stable fixes the issue for me |
|
I’m pretty sure your issue is related to #2905 but let’s try to revert |
|
On the latest downloaded version from the Play Store (3.8.1+722) I still have the crash when I land on the home/camera page: and Full logcat |
|
In your case, it’s coming from the camera driver developed by Samsung. instead we should focus on global scan issues |
|
Could you also create issues per device instead of using this thread, please? |
|
You can have two kinds of issues:
If you are in the second case, please download this APK: drive.google.com/file/d/1F6S0pGpf8OQHhqKSw1opWQPRxpcmYdDV/view?usp=sharing (app name: ML Kit in Flutter) and go to Barcode Scanning (first item) and tell me if you're able to scan. Thanks |
|
Since the alternative mode is now available in the app, what's the plan to check if it fixes the issue? |
|
The feedback we have seem to indicate that the issue is now fixed with the alternative mode. |
|
It think we should consider this issue as fixed with the "alternative mode" enabled by default |
Repository owner
moved this from In Progress
to Done
in 🤳🥫 The Open Food Facts mobile app (Android & iOS)
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
We have a big scan issue. We discussed it at length with @g123k the other day. I'm pinning this until we solve it, and people are happy again.
People are complaining on all channels (email, appstore, app survey)
I believe we didn't ship some of the fixes in the last release, so native bug is still on-going, and people are still complaining: https://github.com/openfoodfacts/smooth-app/pull/2740/files#diff-5898cc81afbf2560f009273208f7247c03d829eabc864ab252c5ef475a713f5eR151
Complaints are focused on Redmi, Oppo, Oneplus
Here's raw user feedback if you'd like to peruse, Scan issues are classified as such: https://docs.google.com/spreadsheets/d/1KsJv8_RxfDDd5ngmeQ4k8ELsudl-YhleXEoDFoGoSAE/edit#gid=1439550856
Linked issues
Permission denials increased 2 folds after update from V1 to Smoothie #2742
We pinpointed this with @g123k. It's probably not the whole story, but might be contributing to it
We might want to explore an isolate as well since people have been complaining about the app freezing
Ensure that CameraX is fully supported for Flutter so that we can use it easily #2381
We might want to explore the new camerax plugin to benefit from whatever little compat gains they did. There's a new plugin in town that might be worth exploring
fix: If the latest barcode is removed from the carousel, it should be scannable again #2746
A product added, then removed, can not be scanned anymore.
The text was updated successfully, but these errors were encountered: