-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The permission workflow for the camera should now be OK #2763
fix: The permission workflow for the camera should now be OK #2763
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2763 +/- ##
==========================================
- Coverage 8.86% 7.16% -1.70%
==========================================
Files 161 218 +57
Lines 6623 10568 +3945
==========================================
+ Hits 587 757 +170
- Misses 6036 9811 +3775 ☔ View full report in Codecov by Sentry. |
@g123k merging if that's ok |
For me, it is :p |
I'd very much like to ship that quickly in order to have a clearer view on scan Issues |
It should only change for iOS users, on Android, it should behave like before (which was OK) |
Which was not ok, I have several videos on my Pixel @g123k ? |
Mmm could you please post one? Or pink an existing issue? |
screen-20220809-105500.mp4 |
I can't reproduce it, so let's say it's ok |
ok, let's merge and see |
Hi everyone,
I have fixed many issues on this PR, but the main change is that it should work far better on iOS.
Basically:
PermissionListener
was created twice -> singletonshouldShowRequestRationale
always returns false on iOS, so the code now takes care of thisThis PR will participate to improve #2741