chore: off-dart 2.3.1 and its new sorted suggestions #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad46236.
# Conflicts: # packages/smooth_app/pubspec.lock # packages/smooth_app/pubspec.yaml
Deleted file: * `tmp_matched_product_v2.dart`: now in off-dart Impacted files: * `personalized_ranking_model.dart`: removed reference to now deleted file `tmp_matched_product_v2.dart` * `personalized_ranking_page.dart`: removed reference to now deleted file `tmp_matched_product_v2.dart` * `Podfile.lock`: wtf * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart to 2.3.1 * `simple_input_text_field.dart`: now using the new `getSuggestions` method that sorts the result
github-actions
bot
added
dependencies
🍎 iOS
Codecov Report
@@ Coverage Diff @@
## develop #3717 +/- ##
===========================================
+ Coverage 10.41% 10.45% +0.03%
===========================================
Files 273 272 -1
Lines 13795 13746 -49
===========================================
Hits 1437 1437
+ Misses 12358 12309 -49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @M123-dev for the review! |
|
It is a thumbs up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted file:
tmp_matched_product_v2.dart: now in off-dartImpacted files:
personalized_ranking_model.dart: removed reference to now deleted filetmp_matched_product_v2.dartpersonalized_ranking_page.dart: removed reference to now deleted filetmp_matched_product_v2.dartPodfile.lock: wtfpubspec.lock: wtfpubspec.yaml: upgraded off-dart to 2.3.1simple_input_text_field.dart: now using the newgetSuggestionsmethod that sorts the resultWhat
Screenshot