fix: 3723 - now always replaces decimal separator for number format #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad46236.
# Conflicts: # packages/smooth_app/pubspec.lock # packages/smooth_app/pubspec.yaml
Impacted files: * `strings_helper.dart`: removed now useless methods * `text_input_formatters_helper.dart`: now works in all cases, regardless of the presence of group separator in the target language, given that we don't use group separators in our decimal number formats anyway
|
Thank you very much @monsieurtanuki |
teolemon
approved these changes
Feb 23, 2023
| @@ -107,10 +103,9 @@ class DecimalSeparatorRewriter extends TextInputFormatter { | |||
| /// Replaces a "." by a "," or a "," by a "." only if | |||
| /// the group separator is an empty character | |||
There was a problem hiding this comment.
the comment about the group separator being an empty character should now be removed I guess
| /// | ||
| /// Also, if a separator is already displayed, it will be move to the new | ||
| /// Also, if a separator is already displayed, it will be moved to the new | ||
| /// position | ||
| class DecimalSeparatorRewriter extends TextInputFormatter { |
There was a problem hiding this comment.
It would be great to have unit tests for those functions, as it would be easy to break something that works today in future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
strings_helper.dart: removed now useless methodstext_input_formatters_helper.dart: now works in all cases, regardless of the presence of group separator in the target language, given that we don't use group separators in our decimal number formats anywayWhat
en_US, it was disabled.6,85which in US was parsed as685.,(and decimal is.) the string fix was problematic.,device and a.app. Typically, when the user is (was) able to type6,85while the app language was set toen_US.Fixes bug(s)