[hdpowerview] Support refresh command for battery-related channels #11933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#11932 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
lolodomo
requested changes
Jan 2, 2022
.../src/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewShadeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
lolodomo
added
the
enhancement
This was referenced Jan 2, 2022
jlaur
changed the title
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11932
As natural evolution after:
we should hard-refresh battery level also when receiving REFRESH command. The REFRESH command now correctly takes the channel into consideration:
Even before those mentioned pull requests, REFRESH for channel lowBattery would wrongly refresh shade positions, which had absolutely no effect for that channel. With #11260 battery refresh was introduced, making it possible to refresh exactly that.
Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk