Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Support refresh command for signal strength channel #11944

Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 2, 2022

Fixes #11942

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

Channel signalStrength was added by #11198 while #11933 refactored the REFRESH command for shades to be relative to channel for requested item. The missing piece now is the signalStrength channel which currently cannot be refreshed on request.

This pull request makes the REFRESH command for shades feature complete as each channel now has a dedicated method assigned for requesting a hard refresh for the item context.

Tested with both negative result:

2022-01-03 00:52:58.796 [TRACE] [rview.internal.HDPowerViewWebTargets] - JSON response = null
2022-01-03 00:52:58.800 [WARN ] [rnal.handler.HDPowerViewShadeHandler] - No response from shade 36321 survey

and positive result:

2022-01-03 00:54:21.764 [INFO ] [openhab.event.ItemCommandEvent      ] - Item 'Blind11_SignalStrength' received command REFRESH
2022-01-03 00:54:40.781 [TRACE] [rview.internal.HDPowerViewWebTargets] - JSON response = {"shade_id":36321,"survey":[{"neighbor_id":17805,"rssi":-86}]}
2022-01-03 00:54:40.783 [DEBUG] [rnal.handler.HDPowerViewShadeHandler] - Survey response for shade 36321: {neighbor:17805, rssi:-86}
2022-01-03 00:54:40.947 [DEBUG] [ternal.handler.HDPowerViewHubHandler] - Updating shade '36321'
2022-01-03 00:54:40.964 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'Blind11_SignalStrength' changed from 0 to 4

Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 5c9da56 into openhab:main Jan 3, 2022
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jan 3, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 3, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur deleted the 11942-hdpowerview-refresh-signal-strength branch June 13, 2022 18:45
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fixes openhab#11942

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hdpowerview] Support refresh of signal strength
2 participants