[max] Remove org.apache.commons

[lsiepel]

• Remove dependency on apache.commons

While some unittests have been provided, not everything is tested, so minor refactoring from code perspective.

Test jar 4.1.0 : https://1drv.ms/u/s!AnMcxmvEeupwjq5YgHLYUNfUqbM3ZQ?e=2oAfZ0

[lsiepel]

@marcelrv are you able to review?

[lsiepel]

@marcelrv Gentle ping

[marcelrv]

@lsiepel sorry I totally missed your earlier inclusion.

I don't see on short notice possibilities to do functional test as I'm redoing my heating and currently don't have the Max operational.

Looking at the code I don't see obvious flaws, so if the tests are passed as well I recommend indeed to merge it

[marcelrv]

LGTM

[lsiepel]

@jlaur can we get this merged before the next milestone?

[jlaur]

can we get this merged before the next milestone?

I don't think I have reviewed this one, unfortunately I don't have time today. Maybe some other @openhab/add-ons-maintainers can help.

[kaikreuzer]

@lsiepel As we meanwhile have a StringUtils class in core, should this new method maybe added there?

[lsiepel]

@jlaur can we get this merged?

[jlaur]

@jlaur can we get this merged?

Yes, let's get it merged. I finally did a review assisted by ChatGPT to reduce cognitive overload for me when comparing the byte copy implementations. 😄

[jlaur]

@lsiepel - this is not my area of expertise, but I'm wondering if this line should be removed as well?

openhab-addons/itests/org.openhab.binding.max.tests/itest.bndrun

Line 65 in 226806d

org.apache.commons.lang3;version='[3.14.0,3.14.1)',\

[lsiepel]

@lsiepel - this is not my area of expertise, but I'm wondering if this line should be removed as well?

openhab-addons/itests/org.openhab.binding.max.tests/itest.bndrun

Line 65 in 226806d

org.apache.commons.lang3;version='[3.14.0,3.14.1)',\

Yeah, was looking into that as you mentioned in the other post. I think this can safely be removed. I’ll come up with a PR