[util] Add abbreviate method to StringUtils #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
|
Is there any other use of this method? It seems a very rare case and should probably be added to the binding code if it is not used elsewhere. |
I cannot oversee all binding code, but i'm not aware at any other usage at this moment in time. As abbreviating strings is a common scenario i would not classify it as very rare. I expect other bindings might benefit in the future too. Besides it is a small method. |
|
It's surely a chicken and egg situation. If the utility is / would be, present. Then it will / would have been, used. |
J-N-K
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to remove the apache libs from the addons i found one more string method that should be moved to this core utility.
It is used in the Max binding, i'll update the related PR accordingly: openhab/openhab-addons#14413