-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[googlestt] Dispose oAuth2 service #14936
Conversation
9a1c728
to
d6228e8
Compare
Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
d6228e8
to
b20ac2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should work, just one minor suggestion. Otherwise LGTM.
...hab.voice.googlestt/src/main/java/org/openhab/voice/googlestt/internal/GoogleSTTService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [googlestt] Dispose oAuth2 service Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
* [googlestt] Dispose oAuth2 service Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Matt Myers <mmyers75@icloud.com>
* [googlestt] Dispose oAuth2 service Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Related to #14818
Signed-off-by: Laurent Garnier lg.hc@free.fr