OAuth2 client : missing calls to ungetOAuthService and deleteServiceAndAccessToken

[lolodomo]

18 bindings use the OAuth2 client provided by the OH core framework.

Only 10 bindings are calling ungetOAuthService. It could be missing for the following bindings:

• hydrawise => PR [hydrawise] Remove the access token when the thing is removed #14945
• livisismarthome => PR [livisismarthome] Remove the access token when the thing is removed #14946
• mercedesme => PR [mercedesme] Remove the access token when the thing is removed #14942
• mielecloud
• myq => PR [myq] Remove the access token when the thing is removed #14938
• nest => PR [nest] Remove the access token when the thing is removed #14940
• googlestt => PR [googlestt] Dispose oAuth2 service #14936
• googletts => PR [googletts] Dispose oAuth2 service #14937

Only ecobee, mielecloud and netatmo bindings are calling deleteServiceAndAccessToken. It could be missing for the following bindings:

• automower => PR [automower] Remove the access token when the thing is removed #14971
• boschindego => PR [boschindego] Refactor OAuth2 implementation #14950
• bticinosmarther
• ecobee => PR [ecobee] Delete OAuth access token when thing removed #14980
• ecowatt => PR [ecowatt] Remove the access token when the thing is removed #14934 and [ecowatt] Change in handleRemoval #14978
• groupepsa => PR [groupepsa] Remove the access token when the thing is removed #14943 and [groupepsa] Small change in handleRemoval #14977
• homeconnect => PR [homeconnect] Remove the access token when the thing is removed #14935
• hydrawise => PR [hydrawise] Remove the access token when the thing is removed #14945 and [hydrawise] Small change in handleRemoval #14976
• livisismarthome => PR [livisismarthome] Remove the access token when the thing is removed #14946 and [livisismarthome] Small change in handleRemoval #14975
• mercedesme => PR [mercedesme] Remove the access token when the thing is removed #14942
• myq => PR [myq] Remove the access token when the thing is removed #14938 and [myq] Small change in handleRemoval #14974
• nest => PR [nest] Remove the access token when the thing is removed #14940
• spotify => PR [spotify] Remove the access token when the thing is removed #14947
• webexteams => PR [webexteams] Remove the access token when the thing is removed #14979
• googlestt : it is a service not attached to a thing, not obvious to determine when removing the access token
• googletts : it is a service not attached to a thing, not obvious to determine when removing the access token

3 bindings are calling addAccessTokenRefreshListener but not removeAccessTokenRefreshListener:

• hydrawise => PR [hydrawise] Remove the access token when the thing is removed #14945
• livisismarthome => PR [livisismarthome] Remove the access token when the thing is removed #14946
• myq => PR [myq] Remove the access token when the thing is removed #14938

[lolodomo]

@jlaur : it is a pity, we did not update the two last ones: bticinosmarther and mielecloud.

[jlaur]

@jlaur : it is a pity, we did not update the two last ones: bticinosmarther and mielecloud.

Yes. For mielecloud I created #14783, but this could be done separately.

[lsiepel]

@lolodomo only a few bindings are left, besides time, any specific reason they are not checked/fixed yet?

[lolodomo]

@lolodomo only a few bindings are left, besides time, any specific reason they are not checked/fixed yet?

I suppose @jlaur and me switched to other PRs.