Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googletts] Dispose oAuth2 service #14937

Merged
merged 2 commits into from
May 5, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented May 5, 2023

Related to #14818

Signed-off-by: Laurent Garnier lg.hc@free.fr

Related to openhab#14818

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the googletts_ungetOAuthService branch from 3e43c2c to 938f108 Compare May 5, 2023 13:29
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor finding, otherwise LGTM.

Also make another improvement.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit d18a524 into openhab:main May 5, 2023
@jlaur jlaur added this to the 4.0 milestone May 5, 2023
@lolodomo lolodomo deleted the googletts_ungetOAuthService branch May 5, 2023 21:11
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
* [googletts] Dispose oAuth2 service

Related to openhab#14818

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
* [googletts] Dispose oAuth2 service

Related to openhab#14818

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [googletts] Dispose oAuth2 service

Related to openhab#14818

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants