-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nest] Remove the access token when the thing is removed #14940
Merged
wborn
merged 2 commits into
openhab:main
from
lolodomo:nest_deleteServiceAndAccessToken
May 13, 2023
Merged
[nest] Remove the access token when the thing is removed #14940
wborn
merged 2 commits into
openhab:main
from
lolodomo:nest_deleteServiceAndAccessToken
May 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
nest_deleteServiceAndAccessToken
branch
from
May 5, 2023 15:12
db73f37
to
5614da7
Compare
jlaur
requested changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. I'll let @wborn have a look also.
....openhab.binding.nest/src/main/java/org/openhab/binding/nest/internal/sdm/api/PubSubAPI.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jlaur
approved these changes
May 5, 2023
wborn
approved these changes
May 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Related to openhab#14818 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14818
Signed-off-by: Laurent Garnier lg.hc@free.fr