Main UI rule triggers when click edit rule if trigger is set to "when system has reached level 70"

[marioschouten]

The problem

When I'm editing rules in the Main-UI normally when you click on "Execute a given script" it opens the script so you can edit it. This behaviour is different when the rule has the trigger "when the system has reached level 70". In that case it runs the rule and you need to click several times to be able to open the scrip to edit, when you save it, it runs the rule again

Expected behavior

When editing /saving a rule it should not start the rule, only when saving or manually starting the rule.

Steps to reproduce

1. Create a rule with trigger "when the system has reached level 70" in OH 4.0.2

Your environment

runtimeInfo:
  version: 4.0.2
  buildString: Release Build
locale: en-TH
systemInfo:
  configFolder: /etc/openhab
  userdataFolder: /var/lib/openhab
  logFolder: /var/log/openhab
  javaVersion: 17.0.8
  javaVendor: Debian
  osName: Linux
  osVersion: 6.1.0-11-amd64
  osArchitecture: amd64
  availableProcessors: 4
  freeMemory: 307486416
  totalMemory: 1507852288
  startLevel: 70
bindings: null
clientInfo:
  device:
    ios: false
    android: false
    androidChrome: false
    desktop: true
    iphone: false
    ipod: false
    ipad: false
    edge: false
    ie: false
    firefox: false
    macos: false
    windows: true
    cordova: false
    phonegap: false
    electron: false
    nwjs: false
    webView: false
    webview: false
    standalone: false
    os: windows
    pixelRatio: 1
    prefersColorScheme: light
  isSecureContext: true
  locationbarVisible: true
  menubarVisible: true
  navigator:
    cookieEnabled: true
    deviceMemory: 8
    hardwareConcurrency: 4
    language: en-GB
    languages:
      - en-GB
      - th-TH
      - th
      - nl-NL
      - nl
    onLine: true
    platform: Win32
  screen:
    width: 3440
    height: 1440
    colorDepth: 24
  support:
    touch: false
    pointerEvents: true
    observer: true
    passiveListener: true
    gestures: false
    intersectionObserver: true
  themeOptions:
    dark: dark
    filled: true
    pageTransitionAnimation: disabled
    bars: light
    homeNavbar: simple
    homeBackground: standard
    expandableCardAnimation: disabled
  userAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
    like Gecko) Chrome/116.0.0.0 Safari/537.36
timestamp: 2023-08-19T04:50:42.334Z

Browser console

Browser network traffic

Additional information

[rkoshak]

When editing/saving a rule it should not start the rule, only when triggered or manually starting the rule.

To be clear, with the behavior of system started/runlevel triggers in OH 4, the rule will trigger when it's saved. That's expected and correct behavior.

However, merely clicking on the rule or a script action should not trigger the rule. Such rule should only be triggered on saving the rule. That's the bug here. The rule triggers even without changing anything meaning the rule should not be reloaded and therefore should not trigger.

[marioschouten]

Thanks, see what you mean and makes sense. Updated accordingly.

[d51x]

I encountered the same problem today, clicked the item with phrase "execute a given script" to edit the rule, and script started. after 20 sec (badge RUNNING) after 20 seconds the script editing form opened

[rkoshak]

I encountered the same problem today, clicked the item with phrase "execute a given script" to edit the rule, and script started. after 20 sec (badge RUNNING) after 20 seconds the script editing form opened

The 20 sec issue is known. See openhab/openhab-addons#15600. There is some evidence that using a 64-bit Java will reduce that initial run of the rule down to 2 seconds.

[d51x]

I encountered the same problem today, clicked the item with phrase "execute a given script" to edit the rule, and script started. after 20 sec (badge RUNNING) after 20 seconds the script editing form opened

The 20 sec issue is known. See openhab/openhab-addons#15600. There is some evidence that using a 64-bit Java will reduce that initial run of the rule down to 2 seconds.

the point is not in 20 seconds, but in the fact that the rule is launched instead of editing

[florian-h05]

The problem is, that the script code editor is opened in a new page, before which the UI saves the rule.
With the changed behaviour of the start level trigger, the rule triggers immediate if the start level is already reached.

I guess the only solution would be to make the script editing happening in a way that the rule does not need to be saved.

[rkoshak]

I guess the only solution would be to make the script editing happening in a way that the rule does not need to be saved.

Could it keep track of whether anything has changed (e.g. triggers) and only save if there is something to save? Even better ask if unsaved changes should be saved before opening the code editor.

[florian-h05]

I thought about this issue a bit, and yes, this should be possible.