Rule edit: Only save rule if it has changed when opening script editor #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#2027. When a script inside a rule was opened, the UI always saved the rule before navigating to the script editor. With this fix, the rule is only saved if there is a change to save. If the rule hasn't been changed, no save request is performed. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1293: Bundle Size — 15.81MiB (+0.29%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1293 report View florian-h05:rules-avoid-save-ons... branch activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2027.
When a script inside a rule was opened, the UI always saved the rule before navigating to the script editor. With this fix, the rule is only saved if there is a change to save. If the rule hasn't been changed, no save request is performed.