Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

940 create more detailed log output #1000

Merged
merged 8 commits into from
Nov 4, 2021
Merged

940 create more detailed log output #1000

merged 8 commits into from
Nov 4, 2021

Conversation

laurenzhonauer
Copy link
Contributor

@laurenzhonauer laurenzhonauer commented Oct 12, 2021 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Closes ModifyMe

@github-actions
Copy link

github-actions bot commented Oct 12, 2021 •
edited
Loading

Warnings
⚠️ There were changes in the frontend, but no E2E-test was added or modified!
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against fc262d2

@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch 2 times, most recently from f83f272 to a161d3e Compare October 12, 2021 09:20
@openkfwCI
Copy link

openkfwCI commented Oct 12, 2021 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededThu, 04 Nov 2021 08:46:46 +0000

Generated by E2E-Test

@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch 2 times, most recently from 0649d87 to 3c71583 Compare October 14, 2021 08:15
@mayrmartin mayrmartin force-pushed the 940-create-more-detailed-log-output branch from 28caceb to 4d1a57f Compare October 19, 2021 07:38
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch 3 times, most recently from e1aa3a6 to 5060d3b Compare October 27, 2021 09:10
@mayrmartin mayrmartin force-pushed the 940-create-more-detailed-log-output branch from 5060d3b to 66a87e1 Compare October 27, 2021 09:40
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch from 66a87e1 to 03fc7fe Compare October 27, 2021 11:28
@mayrmartin mayrmartin force-pushed the 940-create-more-detailed-log-output branch 4 times, most recently from 7b8fcf5 to 93bd225 Compare October 28, 2021 10:05
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch 2 times, most recently from 1bae695 to 0c3e78c Compare October 28, 2021 10:30
laurenzhonauer
laurenzhonauer commented Oct 28, 2021
View reviewed changes
api/src/network/controller/listActive.ts Show resolved Hide resolved
api/src/network/controller/vote.ts Show resolved Hide resolved
api/src/organization/organization.ts Outdated Show resolved Hide resolved
api/src/organization/organization.ts Show resolved Hide resolved
api/src/service/domain/document/storage_service_url_update.ts Outdated Show resolved Hide resolved
logging-service/package.json Outdated Show resolved Hide resolved
logging-service/serve.js Outdated Show resolved Hide resolved
logging-service/serve.js Outdated Show resolved Hide resolved
logging-service/serve.js Outdated Show resolved Hide resolved
scripts/development/.env_example_slim Outdated Show resolved Hide resolved
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch 4 times, most recently from 0038470 to ca51609 Compare November 3, 2021 06:59
@mayrmartin mayrmartin force-pushed the 940-create-more-detailed-log-output branch from 19b696f to 4364686 Compare November 3, 2021 11:15
@mayrmartin @laurenzhonauer
api:
336e308 
- add trace logging to api
- add path aliases for lib import
@mayrmartin @laurenzhonauer
blockchain:
8de41e5 
- add trace output
- print multichain debug messages on stdout
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch from 00a6bb7 to 5cebc2c Compare November 3, 2021 13:59
@laurenzhonauer laurenzhonauer marked this pull request as ready for review November 3, 2021 14:49
@mayrmartin mayrmartin self-requested a review November 3, 2021 15:02
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch from 5cebc2c to 632aceb Compare November 4, 2021 07:33
@mayrmartin @laurenzhonauer
email-notification:
213fbd2 
- add trace messages to logging
@mayrmartin @laurenzhonauer
excel-export:
8997c07 
- add trace messages for logging
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch from 632aceb to de957cd Compare November 4, 2021 07:53
@laurenzhonauer laurenzhonauer force-pushed the 940-create-more-detailed-log-output branch from de957cd to fc262d2 Compare November 4, 2021 08:08
@laurenzhonauer laurenzhonauer merged commit 07f5fc1 into master Nov 4, 2021
@laurenzhonauer laurenzhonauer deleted the 940-create-more-detailed-log-output branch November 4, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayrmartin mayrmartin mayrmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurenzhonauer @openkfwCI @mayrmartin