Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view history #172

Merged
merged 7 commits into from
Apr 2, 2019
Merged

Fix view history #172

merged 7 commits into from
Apr 2, 2019

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Mar 28, 2019

This fixes should solve #87 and #85. I am aiming for a complete and readable history where items are shown in the right direction from new to old.

@mathiashoeld
Copy link
Contributor

@Stezido this does not seem to work properly yet. after provisioning, the history cannot be loaded.

… in saga

ui: do not show documents added message if a normal update happened
@Stezido Stezido requested review from kevinbader and removed request for gonzochic April 1, 2019 09:08
api/src/project_view_details.ts Outdated Show resolved Hide resolved
api/src/project_view_history.ts Outdated Show resolved Hide resolved
api/src/project_view_history.ts Outdated Show resolved Hide resolved
api/src/service/cache2.ts Outdated Show resolved Hide resolved
api/src/service/cache2.ts Outdated Show resolved Hide resolved
api/src/service/subproject_permission_grant.ts Outdated Show resolved Hide resolved
api/src/subproject_view_details.ts Outdated Show resolved Hide resolved
frontend/src/pages/SubProjects/reducer.js Outdated Show resolved Hide resolved
frontend/src/pages/Workflows/reducer.js Outdated Show resolved Hide resolved
…, log aggregate errors at debug level instead of warn; ui: concat array since historyitems are not immutable
@Stezido Stezido requested a review from kevinbader April 1, 2019 14:53
api/src/service/domain/workflow/subproject_get.ts Outdated Show resolved Hide resolved
api/src/service/domain/workflow/subproject_list.ts Outdated Show resolved Hide resolved
api/src/service/domain/workflow/workflowitem_list.ts Outdated Show resolved Hide resolved
frontend/src/pages/SubProjects/ProjectHistoryContainer.js Outdated Show resolved Hide resolved
frontend/src/pages/Workflows/SubProjectHistoryContainer.js Outdated Show resolved Hide resolved
@Stezido Stezido requested a review from kevinbader April 1, 2019 16:08
kevinbader
kevinbader previously approved these changes Apr 2, 2019
@Stezido Stezido merged commit db5cd3b into master Apr 2, 2019
@Stezido
Copy link
Contributor Author

Stezido commented Apr 2, 2019

Closes #85
Closes #87

@Stezido Stezido deleted the fix-view-history branch April 2, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants