Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api, frontend: autocheck file integrity #1940

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Aug 13, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. You will need to replace a file directly on storage, I tested with azurite and azure storage explorer
  2. Start TB in full mode, provisioned
  3. Amazonas Fund > Furniture has a workflow item with two files, both of which can be downloaded and have correct hash
  4. Using azure storage explorer or other tool, note down the file metadata
  5. Using the same tool, delete a file. Upload a different file with the same name and set metadata to previous values
  6. Using TB UI, there should now be a warning about incorrect hash and a log in api console
Screenshot 2024-08-15 at 09 53 46

Closes #1924

Copy link

github-actions bot commented Aug 13, 2024

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 45c19cc

@openkfwCI
Copy link

openkfwCI commented Aug 15, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60197 on remote server failedThu, 22 Aug 2024 08:17:28 +0000

Generated by E2E-Test

@SamuelPull SamuelPull marked this pull request as ready for review August 19, 2024 12:21
@galethil galethil self-requested a review August 22, 2024 07:11
@SamuelPull SamuelPull assigned SamuelPull and galethil and unassigned SamuelPull Aug 22, 2024
@SamuelPull SamuelPull merged commit 831c587 into main Aug 23, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 1924-file-integrity branch August 23, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically check file integrity using a hash
3 participants