api, frontend: autocheck file integrity

api/src/service/domain/document/document.ts

@@ -46,6 +46,11 @@ export interface ExternalLinkReference {
 
 export type DocumentOrExternalLinkReference = DocumentReference | ExternalLinkReference;
 
+export type DocumentWithAvailability = DocumentOrExternalLinkReference & {
+  isValidHash?: boolean;
+  message?: string;
+};
+
 export const documentReferenceSchema = Joi.alternatives([
   Joi.object({
     id: Joi.string().required(),

api/src/service/domain/workflow/workflowitem_get_details.ts

@@ -6,6 +6,7 @@ import { NotAuthorized } from "../errors/not_authorized";
 import { NotFound } from "../errors/not_found";
 import { ServiceUser } from "../organization/service_user";
 import * as Workflowitem from "./workflowitem";
+import { DocumentReference } from "../document/document";
 
 interface Repository {
   getWorkflowitem(): Promise<Result.Type<Workflowitem.Workflowitem>>;
@@ -43,13 +44,39 @@ export async function getWorkflowitemDetails(
 async function setDocumentAvailability(
   documents: WorkflowitemDocument.DocumentOrExternalLinkReference[],
   repository: Repository,
-): Promise<WorkflowitemDocument.DocumentOrExternalLinkReference[]> {
-  const docsWithAvailability: WorkflowitemDocument.DocumentOrExternalLinkReference[] = [];
+): Promise<WorkflowitemDocument.DocumentWithAvailability[]> {
+  const docsWithAvailability: WorkflowitemDocument.DocumentWithAvailability[] = [];
 
   for (const doc of documents) {
     const result = await repository.downloadDocument(doc.id);
-    docsWithAvailability.push({ ...doc, available: Result.isOk(result) });
+    if (Result.isOk(result) && isDocumentReference(doc)) {
+      const actualHash = await WorkflowitemDocument.hashBase64String(result.base64);
+      const isIdentical = isSameHash(doc, actualHash);
+      if (!isIdentical) {
+        logger.warn(
+          `Document ${doc.id} has a different hash than expected. Expected: ${
+            (doc as DocumentReference).hash
+          }, actual: ${actualHash}`,
+        );
+      }
+      docsWithAvailability.push({
+        ...doc,
+        available: Result.isOk(result),
+        isValidHash: isIdentical,
+      });
+    } else {
+      docsWithAvailability.push({ ...doc, available: Result.isOk(result) });
+    }
   }
 
   return docsWithAvailability;
 }
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+function isDocumentReference(doc: any): doc is DocumentReference {
+  return doc && typeof doc.hash === "string";
+}
+
+function isSameHash(doc: DocumentReference, actualHash: string): boolean {
+  return doc.hash === actualHash;
+}

api/src/workflowitem_view_details.ts

@@ -10,7 +10,7 @@ import { Ctx } from "./lib/ctx";
 import { toUnixTimestampStr } from "./lib/datetime";
 import { isNonemptyString } from "./lib/validation";
 import * as Result from "./result";
-import { DocumentOrExternalLinkReference } from "./service/domain/document/document";
+import { DocumentWithAvailability } from "./service/domain/document/document";
 import { ServiceUser } from "./service/domain/organization/service_user";
 import * as Workflowitem from "./service/domain/workflow/workflowitem";
 import Type from "./service/domain/workflowitem_types/types";
@@ -100,10 +100,10 @@ function mkSwaggerSchema(server: AugmentedFastifyInstance): Object {
                               id: {
                                 type: "string",
                                 example: "abc-cde-adf",
-                                additionalProperties: true,
                               },
                               available: { type: "boolean", example: true },
                             },
+                            additionalProperties: true,
                           },
                         },
                       },
@@ -137,7 +137,7 @@ interface ExposedWorkflowitem {
     billingDate: string | null | undefined;
     dueDate: string | null | undefined;
     exchangeRate: string | null | undefined;
-    documents: DocumentOrExternalLinkReference[];
+    documents: DocumentWithAvailability[];
     additionalData: object;
     workflowitemType: Type | undefined;
   };

frontend/src/pages/Documents/DocumentOverview.js

@@ -181,7 +181,10 @@ class DocumentOverview extends Component {
     const header = this.generateDocumentListHeader();
     const rows = documents.map((document, index) => {
       let validated = undefined;
-      const { id, fileName, hash } = document;
+      const { id, fileName, hash, isValidHash } = document;
+      const fingerPrintClassName =
+        isValidHash === false ? "finger-print-container invalid-hash" : "finger-print-container";
+      const fingerPrintText = isValidHash === false ? `Invalid hash ${hash}. File corrupt.` : hash;
       validated = validatedDocuments[id];
 
       return (
@@ -195,9 +198,9 @@ class DocumentOverview extends Component {
                 <div className="document-link">{document.link}</div>
               </Tooltip>
             ) : (
-              <div className="finger-print-container">
+              <div className={fingerPrintClassName}>
                 <FingerPrint className="finger-print" />
-                <OverflowTooltip text={hash} maxWidth="4.375rem" />
+                <OverflowTooltip text={fingerPrintText} />
               </div>
             )}
           </TableCell>

frontend/src/pages/Documents/DocumentOverview.scss

@@ -41,3 +41,7 @@
   padding-right: 0.625rem;
   padding-bottom: 0.625rem;
 }
+
+.invalid-hash {
+  color: red;
+}