Feat Automatic cdn invalidation #665
Conversation
commit: |
| //TODO: test the constructed paths | ||
| const constructedPaths = paths.flatMap(({ path, isAppRouter }) => | ||
| isAppRouter | ||
| ? [`${path}`, `${path}?_rsc=*`] |
There was a problem hiding this comment.
I think only ${path}* is enough here? I will do some testing tommorow btw.
There was a problem hiding this comment.
It's on purpose ${path}* would invalidate every route that start with path. For example if you have a products and a products/[slug] route (using ${path}*) it would be impossible to invalidate only products
There was a problem hiding this comment.
I think it also invalidates the products if you use the ${path}* one actually.
There was a problem hiding this comment.
That's not what i'm saying, it invalidates products but also every single products/[slug] route, which may not be what you want
There was a problem hiding this comment.
but yeah im guessing we dont want that. its probably wise to only invalidate the path.
in my projects im just used to doing the star, cause normally you would want products and products/[slug] invalidated at the same time.
There was a problem hiding this comment.
The paths need to have a leading / else an error will be thrown from cloudfront client: Failed to revalidate tag InvalidArgument: Your request contains one or more invalid invalidation paths.
There was a problem hiding this comment.
@sommeeeer It's only for revalidateTag right ? You didn't test res.revalidate ?
There was a problem hiding this comment.
It's only for
revalidateTagright ? You didn't testres.revalidate?
i tested revalidatePath('/products');
There was a problem hiding this comment.
This works:
const constructedPaths = paths.flatMap(({ path, isAppRouter }) =>
isAppRouter
? [`/${path}`, `/${path}?_rsc=*`]
: [
`/${path}`,
`/_next/data/${process.env.BUILD_ID}${path === "/" ? "/index" : path}.json*`,
],
);
|
Fix #658
Still a bit of work to do on this one, it will require a refactor of
InternalEvent(orRoutingResult) and the routingHandler so that we have access to the information we need (Or maybe we can use the async hook context)