add additional metadata to RoutingResult #673
Conversation
🦋 Changeset detectedLatest commit: 0be8461 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
| @@ -31,3 +31,4 @@ export const AppPathsManifestKeys = | |||
| /* @__PURE__ */ loadAppPathsManifestKeys(NEXT_DIR); | |||
| export const MiddlewareManifest = | |||
| /* @__PURE__ */ loadMiddlewareManifest(NEXT_DIR); | |||
| export const AppPathsManifest = loadAppPathsManifest(NEXT_DIR); | |||
There was a problem hiding this comment.
Do we need /* @__PURE__ */ here?
There was a problem hiding this comment.
Probably not for all of them, but this is necessary for some part. Without it esbuild fail to remove some of the unused one and it can cause error at runtime
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| "@opennextjs/aws": patch | |||
There was a problem hiding this comment.
Maybe this should be minor (new feature) instead of patch (bug fix) ?
There was a problem hiding this comment.
I think it's ok this way, technically there is no new feature here, and it should have no impact at all for end user (even people with custom overrides)
Other PR that will depend on this one will be minor like #665
This PR will help #665.
This may also allow us in the future to use https://github.com/vercel/next.js/blob/4d1613d049037b2b39295a9479c9f8c9a12df907/packages/next/src/server/base-server.ts#L1581 instead of
getRequestHandler