Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Vis Builder] Incorrect index pattern causes multiple errors #2643

Closed
ashwin-pc opened this issue Oct 21, 2022 · 1 comment · Fixed by #3732 or #3752
Closed

[BUG] [Vis Builder] Incorrect index pattern causes multiple errors #2643

ashwin-pc opened this issue Oct 21, 2022 · 1 comment · Fixed by #3732 or #3752
Assignees
@ashwin-pc
Labels
bug Something isn't working v2.7.0 vis builder

Comments

@ashwin-pc
Copy link
Member

Describe the bug

For the error in #2631 there were multiple error toasts displayed for a single error.

To Reproduce
Steps to reproduce the behavior:

  1. Have a mis configured index pattern
  2. Go to Vis Builder
  3. See error

Expected behavior
The error toast should only show up once.

OpenSearch Version
3.0

Dashboards Version
3.0

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.
@ashwin-pc ashwin-pc added bug Something isn't working vis builder labels Oct 21, 2022
@ashwin-pc ashwin-pc mentioned this issue Oct 21, 2022
Closed
@ashwin-pc ashwin-pc mentioned this issue Nov 14, 2022
Open
@ashwin-pc
Copy link
Member Author

Enhancing notifications tracked in a separate issue #3059

@AbhishekReddy1127 AbhishekReddy1127 removed their assignment Mar 27, 2023
@ashwin-pc ashwin-pc self-assigned this Mar 28, 2023
This was referenced Mar 29, 2023
Closed
Merged
Merged
@ashwin-pc ashwin-pc mentioned this issue Apr 6, 2023
Open
kavilla pushed a commit that referenced this issue Apr 17, 2023
@ashwin-pc @seanneumann @joshuarrrr
Adds toast ID to toast api (#3752)
14bde2b 
* Currently sending the same toast multiple times results in multiple toasts being rendered on the screen. This change allows the toast api to additionally accept an id parameter that
* Update changelog
* Update src/core/public/notifications/toasts/toasts_api.tsx

Issue Resolved:
#2643

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Co-authored-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 17, 2023
@github-actions
Adds toast ID to toast api (#3752)
9dfdf44 
* Currently sending the same toast multiple times results in multiple toasts being rendered on the screen. This change allows the toast api to additionally accept an id parameter that
* Update changelog
* Update src/core/public/notifications/toasts/toasts_api.tsx

Issue Resolved:
#2643

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Co-authored-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 14bde2b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ashwin-pc pushed a commit that referenced this issue Apr 18, 2023
@opensearch-trigger-bot @github-actions
@joshuarrrr @ananzh
[Backport 2.x] Adds toast ID to toast api (#3868)
7447079 
* Adds toast ID to toast api (#3752)

* Currently sending the same toast multiple times results in multiple toasts being rendered on the screen. This change allows the toast api to additionally accept an id parameter that
* Update changelog
* Update src/core/public/notifications/toasts/toasts_api.tsx

Issue Resolved:
#2643

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Co-authored-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 14bde2b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

* add changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
@jhenley-icr-team jhenley-icr-team mentioned this issue Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwin-pc ashwin-pc

Labels
bug Something isn't working v2.7.0 vis builder
Projects
None yet
Milestone
No milestone
2 participants
@ashwin-pc @AbhishekReddy1127