Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De-Angular] More angular test cleaning #5020

Closed
2 tasks
ananzh opened this issue Sep 14, 2023 · 2 comments
Closed
2 tasks

[De-Angular] More angular test cleaning #5020

ananzh opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
de-angular de-angularize work v2.11.0

Comments

@ananzh
Copy link
Member

ananzh commented Sep 14, 2023

  • Remove/Replace test/plugin_functional/plugins/doc_views_plugin/public/plugin.tsx
  • Remove/Replace test/plugin_functional/test_suites/doc_views/doc_views.ts.
@ananzh ananzh added de-angular de-angularize work v2.11.0 labels Sep 14, 2023
@ananzh ananzh removed the untriaged label Sep 14, 2023
@joshuarrrr
Copy link
Member

@ananzh Should this be relabeled for 2.12?

@ananzh
Copy link
Member Author

ananzh commented Oct 3, 2023

I will see if I have time to work on it tmrw. Otherwise, I will re-label it.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
opensearch-project#5020

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
…e tests

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
opensearch-project#5020

Signed-off-by: ananzh <ananzh@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Oct 5, 2023
…e tests (#5221)

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
#5020

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 70b9eea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh pushed a commit that referenced this issue Oct 5, 2023
…e tests (#5221) (#5224)

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
#5020

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 70b9eea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this issue Oct 5, 2023
…e tests (opensearch-project#5221)

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
opensearch-project#5020

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
…e tests (opensearch-project#5221)

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
opensearch-project#5020

Signed-off-by: ananzh <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
de-angular de-angularize work v2.11.0
Projects
None yet
Development

No branches or pull requests

2 participants