[Backport 2.x] [Tests-refactor] Remove angular code from plugin_functional and update tests #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…e tests (#5221) * remove angular-based view from DocViewsPlugin * remove the test case that validates the display and content of the angular doc view Issue Resolve #5020 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 70b9eea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
opensearch-trigger-bot
bot
added
test:functional
de-angular
Codecov Report
@@ Coverage Diff @@
## 2.x #5224 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 3278 3278
Lines 63062 63062
Branches 10033 10033
=======================================
Hits 42125 42125
- Misses 18470 18550 +80
+ Partials 2467 2387 -80
Flags with carried forward coverage won't be shown. Click here to find out more. |
ashwin-pc
approved these changes
Oct 5, 2023
ananzh
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 70b9eea from #5221.