-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] show region blocked warning config not respected #2042
[BUG] show region blocked warning config not respected #2042
Conversation
The configuration wasn't passed down to the options that was expecting it to be available for the plugin to run the conditional logic. Value was undefined for region map. Also, cleaned up the vega map view code. Issue: opensearch-project#2041 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2042 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 3076 3077 +1
Lines 59144 59188 +44
Branches 8989 9003 +14
=======================================
+ Hits 39919 39954 +35
- Misses 17041 17048 +7
- Partials 2184 2186 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A screenshot would be helpful to illustrate what this actually changes or fixes.
To recreate go to region map and you can see that Example on main after setting the config to true: But on this branch you can see the value for example: Right now the config value does get set but the logic checks an object that never included the config value so this adds it to the object that the logic is expecting to read. The reason why this made it through is because right now |
The configuration wasn't passed down to the options that was expecting it to be available for the plugin to run the conditional logic. Value was undefined for region map. Also, cleaned up the vega map view code. Issue: #2041 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 5fb4143)
The configuration wasn't passed down to the options that was expecting it to be available for the plugin to run the conditional logic. Value was undefined for region map. Also, cleaned up the vega map view code. Issue: #2041 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 5fb4143) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…oject#2042) The configuration wasn't passed down to the options that was expecting it to be available for the plugin to run the conditional logic. Value was undefined for region map. Also, cleaned up the vega map view code. Issue: opensearch-project#2041 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Description
The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.
Value was undefined for region map. Also, cleaned up the vega map
view code.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#2041
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr