[BUG] show region blocked warning config not respected

[kavilla]

Description

The configuration wasn't passed down to the options that was
expecting it to be available for the plugin to run the conditional
logic.

Value was undefined for region map. Also, cleaned up the vega map
view code.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

#2041

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #2042 (b2021a7) into main (54c2cdc) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main    #2042   +/-   ##
=======================================
  Coverage   67.49%   67.50%           
=======================================
  Files        3076     3077    +1     
  Lines       59144    59188   +44     
  Branches     8989     9003   +14     
=======================================
+ Hits        39919    39954   +35     
- Misses      17041    17048    +7     
- Partials     2184     2186    +2     

Impacted Files	Coverage Δ
.../maps_legacy/public/map/base_maps_visualization.js	1.94% <0.00%> (-0.02%)	⬇️
...plugins/maps_legacy/public/map/service_settings.js	1.60% <0.00%> (-0.03%)	⬇️
...ns/vis_type_vega/public/vega_view/vega_map_view.js	54.34% <ø> (ø)
src/plugins/vis_type_vega/public/services.ts	100.00% <100.00%> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	83.67% <0.00%> (-4.09%)	⬇️
packages/osd-optimizer/src/node/cache.ts	50.00% <0.00%> (-2.78%)	⬇️
...ore/public/chrome/ui/header/header_breadcrumbs.tsx	100.00% <0.00%> (ø)
...s/vis_type_vega/public/vega_view/vega_base_view.js	55.55% <0.00%> (ø)
packages/osd-std/src/validate_object.ts	91.30% <0.00%> (ø)
...c/plugins/vis_type_vega/public/data_model/utils.ts	73.33% <0.00%> (+34.87%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

[joshuarrrr]

A screenshot would be helpful to illustrate what this actually changes or fixes.

[kavilla]

A screenshot would be helpful to illustrate what this actually changes or fixes.

To recreate go to region map and you can see that settings.options does not include showRegionBlockedWarning as the code is expecting.

Example on main after setting the config to true:

But on this branch you can see the value for example:

Right now the config value does get set but the logic checks an object that never included the config value so this adds it to the object that the logic is expecting to read. The reason why this made it through is because right now maps_legacy jest tests are ignored. So I created a followup issue to re-enable them and why they were disabled in the first place here: #2057