Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kibana and elasticsearch references #273

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Update kibana and elasticsearch references #273

merged 2 commits into from
Apr 10, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Apr 9, 2021

Description

Update docker file references

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

[Rename] fix file references
56608ff 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested review from ananzh, kavilla and mihirsoni April 9, 2021 23:00
@boktorbb boktorbb added this to the Beta release milestone Apr 9, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed 56608ff

Address PR comments
1649cb4 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from mihirsoni April 9, 2021 23:05
@odfe-release-bot
Copy link

✅   DCO Check Passed 1649cb4

@mihirsoni mihirsoni mentioned this pull request Apr 9, 2021
Closed
5 tasks
mihirsoni
mihirsoni approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ananzh
ananzh approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kavilla kavilla merged commit cadeb74 into opensearch-project:main Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
Beta release
Development

Successfully merging this pull request may close these issues.
5 participants
@boktorbb @odfe-release-bot @mihirsoni @ananzh @kavilla