Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] Fix file name containing word kibana #275

Closed
wants to merge 1 commit into from
Closed

[Rename] Fix file name containing word kibana #275

wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Apr 9, 2021

Signed-off-by: Anan Zhuang ananzh@amazon.com

Description

Fix file name containing word kibana

Issues Resolved

na

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh
Fix file name containing word kibana
a74686b 
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh requested review from mihirsoni, kavilla and boktorbb April 9, 2021 23:15
boktorbb
boktorbb suggested changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already did this in my open PR. This PR can be closed

@odfe-release-bot
Copy link

✅   DCO Check Passed a74686b

@mihirsoni
Copy link
Contributor

Thanks @boktorbb-amzn.

Closing in favor of #273

@mihirsoni mihirsoni closed this Apr 9, 2021
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 4, 2024
@SuZhou-Joe
feat: backport pr 5949 to workspace-pr-inte (opensearch-project#275)
c5050d3 
* feat: merge 5949

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
@SuZhou-Joe
feat: backport pr 5949 to workspace-pr-inte (opensearch-project#275)
0644dcb 
* feat: merge 5949

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boktorbb boktorbb boktorbb requested changes

@mihirsoni mihirsoni Awaiting requested review from mihirsoni

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ananzh @odfe-release-bot @mihirsoni @boktorbb