Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x][MD] Support SigV4 as a new auth type of datasource #3458

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 17, 2023

  • [Multiple DataSource] Add support for SigV4 authentication

Backport Issue

#3058

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…rce (opensearch-project#3058)

* [Multiple DataSource] Add support for SigV4 authentication

Backport Issue
opensearch-project#3058

Signed-off-by: Su <szhongna@amazon.com>
@ananzh ananzh requested a review from a team as a code owner February 17, 2023 22:17
@ananzh ananzh added v2.6.0 multiple datasource multiple datasource project labels Feb 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #3458 (c4bf76a) into 2.x (e484a7a) will decrease coverage by 0.06%.
The diff coverage is 40.41%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3458      +/-   ##
==========================================
- Coverage   66.48%   66.42%   -0.06%     
==========================================
  Files        3203     3205       +2     
  Lines       61397    61551     +154     
  Branches     9453     9492      +39     
==========================================
+ Hits        40821    40888      +67     
- Misses      18315    18396      +81     
- Partials     2261     2267       +6     
Flag Coverage Δ
Linux 66.37% <40.41%> (-0.12%) ⬇️
Windows 66.37% <40.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/validation/datasource_form_validation.ts 75.86% <0.00%> (-24.14%) ⬇️
src/plugins/data_source_management/public/types.ts 100.00% <ø> (ø)
...s_credential_modal/update_aws_credential_modal.tsx 5.26% <5.26%> (ø)
...gins/data_source/server/client/configure_client.ts 46.66% <35.71%> (-19.38%) ⬇️
...rce/components/edit_form/edit_data_source_form.tsx 70.74% <38.35%> (-20.03%) ⬇️
...components/create_form/create_data_source_form.tsx 75.26% <41.66%> (-21.71%) ⬇️
...c/plugins/data_source/server/client/client_pool.ts 46.66% <45.00%> (-12.16%) ⬇️
...ta_source/server/legacy/configure_legacy_client.ts 59.61% <50.00%> (-11.22%) ⬇️
...ata_source/server/client/configure_client_utils.ts 64.70% <64.70%> (ø)
.../plugins/data_source/server/data_source_service.ts 71.42% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@abbyhu2000 abbyhu2000 merged commit 448c755 into opensearch-project:2.x Feb 18, 2023
joshuarrrr added a commit that referenced this pull request Feb 20, 2023
joshuarrrr added a commit that referenced this pull request Feb 20, 2023
… datasource (#3058) (#3458)" (#3464)

This reverts commit 448c755.

Signed-off-by: Josh Romero <rmerqg@amazon.com>
@joshuarrrr joshuarrrr removed the v2.6.0 label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants