-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Manual Backport 2.x][MD] Support SigV4 as a new auth type of datasource" #3464
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #3464 +/- ##
==========================================
+ Coverage 66.42% 66.54% +0.12%
==========================================
Files 3205 3203 -2
Lines 61551 61397 -154
Branches 9492 9453 -39
==========================================
- Hits 40884 40859 -25
+ Misses 18399 18284 -115
+ Partials 2268 2254 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think we can remove the 2.6 label here as well right: #3465? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with reverting this. I don't think the call was to bump to a major version. I think if sigv4 support was a minor change for 2.x it can also be a minor change for 1.x and request can be made to support.
There is no indication that the 1.x version of OpenSearch JS is deprecated: https://www.npmjs.com/package/@opensearch-project/opensearch/v/1.1.0.
We should request if this: opensearch-project/opensearch-js#279 can be backported to 1.x. So that we can get the new feature without causing a breaking change.
cc: @ananzh, @zhongnansu, @abbyhu2000
I think 2.6 is too rushy. We should revert it. Then we should discuss whether we could treat client as a special package and relax the restrict version match. |
Not clear on what specific functionality break changes have occurred that justify the revert We should have a retrospective to revisit and align with the community on the definition break change perf SemVer to improve the process. Otherwise, it will decrease productivity and erode the community's trust. |
Bumping
@opensearch-project/opensearch
from^1.1.0
to^2.1.0
is a breaking change for plugins and CI, and should not have been backported to2.x
Fixes opensearch-project/opensearch-build#3210