[Backport 2.10] [Discover 2.0] fixes add filter and dismissible callout #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fixes add filter and dismissible callout Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes filters applying when loading a saved search Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit b9b2b79) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh and
kavilla
as code owners
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested a review
from seanneumann
as a code owner
opensearch-trigger-bot
bot
requested a review
from AMoo-Miki
as a code owner
opensearch-trigger-bot
bot
requested review from
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
ashwin-pc
approved these changes
Sep 15, 2023
kavilla
approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## 2.10 #5033 +/- ##
==========================================
- Coverage 66.47% 66.47% -0.01%
==========================================
Files 3402 3402
Lines 64977 64980 +3
Branches 10374 10374
==========================================
+ Hits 43196 43197 +1
- Misses 19217 19219 +2
Partials 2564 2564
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b9b2b79 from #5029.