[Fix] ValidationError when setting maps.proxyOpenSearchMapsServiceInMaps

[ShatilKhan]

Description

Swapped the arguments that has been causing Validations error.
swapped places of map.proxyElasticMapsServiceInMaps with map.proxyOpenSearchMapsServiceInMaps

Issues Resolved

Fixes #5122

Screenshot

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[joshuarrrr]

@ShatilKhan Thanks for taking this on! One thing we want from all PRs is a summary of how to test and verify that the fix in the PR actually solves the problem in the issue. Oftentimes that means writing additional tests or test cases. But sometimes it can just be a set of steps, such as in this PR description: #5168

Screenshots or videos can also be helpful in demonstrating the fix, particularly for UI changes.

In this case, you probably want to do 2 things:

1. Make sure you can reproduce the problem as described in [BUG] ValidationError when setting maps.proxyOpenSearchMapsServiceInMaps  #5122. If you can't reproduce on main, there's no way to know if your changes actually fix the issue.
2. On this branch, go through the same reproductions steps to demonstrate that the problem is resolved.

A description of this testing can be added to the "Testing the changes" section in the description. That way any reviewer also can go through the steps if needed.

[codecov]

Codecov Report

Merging #5170 (2d33449) into main (60f4c8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5170   +/-   ##
=======================================
  Coverage   66.77%   66.77%           
=======================================
  Files        3284     3284           
  Lines       63095    63095           
  Branches    10049    10049           
=======================================
  Hits        42134    42134           
  Misses      18488    18488           
  Partials     2473     2473           

Flag	Coverage Δ
Linux_1	35.26% <ø> (ø)
Linux_2	55.24% <ø> (ø)
Linux_3	43.85% <ø> (ø)
Linux_4	35.36% <ø> (ø)
Windows_1	35.27% <ø> (ø)
Windows_2	55.20% <ø> (ø)
Windows_3	43.85% <ø> (ø)
Windows_4	35.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[AMoo-Miki]

I manually made the change suggested by @joshuarrrr and resolved the conflict, in the interest of speeding up the process.

[ShatilKhan]

Thanks for fixing the CHANGELOG @AMoo-Miki
I was a bit busy, I am working on reproducing the bug and adding a few screenshots. I'm not sure if someone else's change will be accepted in this PR. But thanks anyway

[tobiasehlert]

Thanks for fixing the CHANGELOG @AMoo-Miki I was a bit busy, I am working on reproducing the bug and adding a few screenshots. I'm not sure if someone else's change will be accepted in this PR. But thanks anyway

You see in my original issue (#5122 (comment)) what the config was that caused the error to appear.

If you don't get the ValidationError message when configuring the map.proxyOpenSearchMapsServiceInMaps value, then your suggested change should be successful, if not then you are not done yet.

I could have tried writing this PR too, but you wanted to so I'll wait ^_^

[ShatilKhan]

hey @tobiasehlert
Thank you so much for the opportunity. I was a bit busy & still trying to figure things out with this codebase. I'll make an update soon.

[tobiasehlert]

@ShatilKhan, how is it going for you? :)

[ShatilKhan]

Yeah I'm on it @tobiasehlert
I'll give update by tomorrow

stale

[ShatilKhan]

Hi @joshuarrrr
Apologies for my delay
Has this PR been merged?
Should I reproduce the error & send screenshots?

[tobiasehlert]

@ShatilKhan, no the PR is still open so your suggested fix is not implemented yet and waiting for you :)

[joshuarrrr]

@ShatilKhan Reviewers were awaiting some verification testing. Here's an example of how I verified this PR:

1. Reproductions of issue as described in [BUG] ValidationError when setting maps.proxyOpenSearchMapsServiceInMaps  #5122

Screen.Recording.2023-10-16.at.5.21.10.PM.mov

2. Demonstration of the fix (with this PR branch):

Screen.Recording.2023-10-16.at.5.25.18.PM.mov

[joshuarrrr]

LGTM

[ShatilKhan]

Thanks @joshuarrrr
I'll make sure to give regular updates on my upcoming PRs
I was a bit confused about reproducing the issue on this one
Thanks for explaining that part as well!