Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ValidationError when setting maps.proxyOpenSearchMapsServiceInMaps #5170

Merged
merged 5 commits into from
Oct 18, 2023
Merged

[Fix] ValidationError when setting maps.proxyOpenSearchMapsServiceInMaps #5170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a35e7f3
Update index.ts args
ShatilKhan Oct 2, 2023
831bb51
update changelog
ShatilKhan Oct 2, 2023
c1d6ae6
Update CHANGELOG.md
AMoo-Miki Oct 4, 2023
6f30667
Merge branch 'main' into sk
AMoo-Miki Oct 4, 2023
2d33449
Merge branch 'main' into sk
joshuarrrr Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Table Vis] Fix filter actions on data table vis cells ([#4837](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4837))
- Fix broken app when management is turned off ([#4891](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4891))
- Correct the generated path for downloading plugins by their names on Windows ([#4953](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4953))
- Fix `maps.proxyOpenSearchMapsServiceInMaps` config definition so it can be set ([#5170](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5170))
- Fix `buildPointSeriesData` unit test fails due to local timezone ([#4992](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4992))
- [Data Explorer][Discover] Fix total hits issue for no time based data ([#5087](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5087))
- [Data Explorer][Discover] Add onQuerySubmit to top nav and allow force update to embeddable ([#5160](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5160))
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/maps_legacy/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const config: PluginConfigDescriptor<MapsLegacyConfig> = {
schema: configSchema,
deprecations: ({ renameFromRoot }) => [
renameFromRoot('map.includeElasticMapsService', 'map.includeOpenSearchMapsService'),
renameFromRoot('map.proxyOpenSearchMapsServiceInMaps', 'map.proxyElasticMapsServiceInMaps'),
renameFromRoot('map.proxyElasticMapsServiceInMaps', 'map.proxyOpenSearchMapsServiceInMaps'),
renameFromRoot(
'map.regionmap.includeElasticMapsService',
'map.regionmap.includeOpenSearchMapsService'
Expand Down
Loading