Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fixes recently accessed #5258

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[Discover] Fixes recently accessed #5258

merged 1 commit into from
Oct 10, 2023

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Oct 10, 2023 •
edited
Loading

Description

Fixes accessing saved searches from recently accessed and adding visited saved searches to recently accessed. Also has a few small fixes to the code

Issues Resolved

fixes #5254

Screenshot

Screen.Recording.2023-10-10.at.2.39.09.AM.mov

Testing the changes

  • Go to 'Discover'.
  • Add some columns
  • Save it.
  • Click side nav menu and select saved search from step 2.
  • See saved search is loaded.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ashwin-pc
Fixes recently accessed
663d675 
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry backport 2.x v2.11.0 backport 2.11 discover for discover reinvent de-angular de-angularize work and removed distinguished-contributor labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #5258 (663d675) into main (d6345f3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5258   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files        3284     3284           
  Lines       63092    63092           
  Branches    10048    10048           
=======================================
+ Hits        42133    42138    +5     
+ Misses      18491    18478   -13     
- Partials     2468     2476    +8
Flag Coverage Δ
Linux_1 35.26% <0.00%> (ø)
Linux_2 55.24% <ø> (ø)
Linux_3 43.84% <0.00%> (ø)
Linux_4 35.36% <ø> (-0.01%) ⬇️
Windows_1 35.32% <0.00%> (+0.04%) ⬆️
Windows_2 55.20% <ø> (ø)
Windows_3 43.85% <0.00%> (ø)
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ns/discover/public/saved_searches/_saved_search.ts 9.09% <0.00%> (ø)

... and 9 files with indirect coverage changes

@ashwin-pc ashwin-pc changed the title Fixes recently accessed [Discover] Fixes recently accessed Oct 10, 2023
@ashwin-pc ashwin-pc merged commit 5f45553 into opensearch-project:main Oct 10, 2023
75 of 91 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
Fixes recently accessed (#5258)
8ec792c 
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 5f45553)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
Fixes recently accessed (#5258)
c7f72ee 
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 5f45553)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023
Merged
ananzh pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @github-actions
Fixes recently accessed (#5258) (#5262)
15cf7b5 
(cherry picked from commit 5f45553)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Oct 10, 2023
@opensearch-trigger-bot @github-actions
Fixes recently accessed (#5258) (#5263)
27f0834 
(cherry picked from commit 5f45553)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x de-angular de-angularize work discover for discover reinvent Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][Data Explorer][Discover] Saved search is not loaded from side nav menu
3 participants
@ashwin-pc @AMoo-Miki @kavilla