[OSCI] removed KUI usage in visualizations #5462
Conversation
Signed-off-by: Cailey Jen <caileyjen@gmail.com>
caileyjen
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Cailey Jen <63242227+caileyjen@users.noreply.github.com>
| className="kuiVerticalRhythm visDisabledLabVisualization__icon kuiIcon fa-flask" | ||
| aria-hidden="true" | ||
| <EuiEmptyPrompt | ||
| iconType="database" |
There was a problem hiding this comment.
Seems icon "beaker" makes a bit more sense here? cuz it is experimental?
| <Fragment> | ||
| <p> | ||
| Enable experimental visualizations within{' '} | ||
| <EuiLink href="https://github.com/app/management/opensearch-dashboards/settings"> |
There was a problem hiding this comment.
Using a url directly seems not the best way to do this? According to #3208, doc links should be from DocLinksService. Some places you could check:
- src/core/public/doc_links/doc_links_service.ts: could add a section
management: { advancedSettingsLink: "**"}for Dashboards Management links - src/plugins/visualizations/public/services.ts: import
DocLinksStartand addexport const [getDocLinks, setDocLinks] = createGetterSetter<DocLinksStart>('docLinks'); - src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx: use
getDocLinksto get the link and use it in href.
The links seems not correct to me as well. https://github.com/app/management/opensearch-dashboards/settings is 404. I think this https://opensearch.org/docs/latest/dashboards/management/advanced-settings/ might be the one if you are trying to direct people to instructions on how to use advanced settings.
There was a problem hiding this comment.
Thank you! I wasn't completely sure about what I was supposed to link to. I'll make the appropriate changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5462 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 3291 3291
Lines 63174 63174
Branches 10055 10055
=======================================
Hits 42213 42213
- Misses 18479 18551 +72
+ Partials 2482 2410 -72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@caileyjen Just checking in to see if you will be able to make some of Anan's suggestions. |
This PR completes opensearch-project#5462 Please refer to the above PR for more details Signed-off-by: Anan Zhuang <ananzh@amazon.com>
…PR (#6360) (#6407) This PR completes #5462 Please refer to the above PR for more details Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 46b17e4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Removed KUI classes in the
DisabledLabVisualizationcomponentChanged placeholder text and icon should be with
OuiEmptyPromptUpdated text to "[vispanel title] is an experimental visualization. Enable experimental visualizations within Advanced Settings."
Issues Resolved
#3386
Screenshot
Testing the changes
How to view the
DisabledVabVisualizationcomponentCheck List
yarn test:jestyarn test:jest_integration