-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource] Add installedPlugins list to data source saved … #6348
Conversation
…object Signed-off-by: Zilong Xia <zilongx@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
==========================================
+ Coverage 67.51% 67.53% +0.01%
==========================================
Files 3377 3377
Lines 65843 65854 +11
Branches 10649 10650 +1
==========================================
+ Hits 44455 44474 +19
+ Misses 18804 18794 -10
- Partials 2584 2586 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zilong Xia <zilongx@amazon.com>
@@ -141,6 +141,7 @@ export interface DataSourceAttributes extends SavedObjectAttributes { | |||
description?: string; | |||
endpoint?: string; | |||
dataSourceVersion?: string; | |||
installedPlugins?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to expose getters for the installed plugins and version fields for plugins to use so that they don't need to know implementation details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, will wrap the field in getters in next one, this one will be focusing on adding the installedPlugins first ~
#6348) * [Multiple Datasource] Add installedPlugins list to data source saved object Signed-off-by: Zilong Xia <zilongx@amazon.com> * [Multiple Datasource] Fix create data source wizard test Signed-off-by: Zilong Xia <zilongx@amazon.com> --------- Signed-off-by: Zilong Xia <zilongx@amazon.com> (cherry picked from commit 7406205) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
#6348) (#6351) * [Multiple Datasource] Add installedPlugins list to data source saved object Signed-off-by: Zilong Xia <zilongx@amazon.com> * [Multiple Datasource] Fix create data source wizard test Signed-off-by: Zilong Xia <zilongx@amazon.com> --------- Signed-off-by: Zilong Xia <zilongx@amazon.com> (cherry picked from commit 7406205) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This change is the second step per RFC [RFC] Plugins Version Decoupling #5877 aiming at decouple the strict version constrains between OSD Core and Plugins
This change adds new attribute
installedPlugins
into thedata-source
saved object, which then will be leveraged by each plugin/component to filter out supported data sources based on individual plugin dependencyIssues Resolved
#6349
Screenshot
data-source
saved object , withinstalledPlugins
addedTesting the changes
All related test cases passed as
Check List
yarn test:jest
yarn test:jest_integration