Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Multiple Datasource] Add installedPlugins list to data source saved … #6351

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7406205 from #6348.

#6348)

* [Multiple Datasource] Add installedPlugins list to data source saved object

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* [Multiple Datasource] Fix create data source wizard test

Signed-off-by: Zilong Xia <zilongx@amazon.com>

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
(cherry picked from commit 7406205)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.36%. Comparing base (88ab834) to head (87d7793).

Files Patch % Lines
.../server/routes/data_source_connection_validator.ts 80.00% 1 Missing and 1 partial ⚠️
.../data_source_management/public/components/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6351      +/-   ##
==========================================
+ Coverage   67.34%   67.36%   +0.02%     
==========================================
  Files        3344     3344              
  Lines       64874    64885      +11     
  Branches    10396    10397       +1     
==========================================
+ Hits        43692    43713      +21     
+ Misses      18655    18644      -11     
- Partials     2527     2528       +1     
Flag Coverage Δ
Linux_1 31.30% <ø> (ø)
Linux_2 55.39% <ø> (ø)
Linux_3 45.10% <83.33%> (+<0.01%) ⬆️
Linux_4 35.20% <0.00%> (ø)
Windows_1 31.35% <ø> (+0.02%) ⬆️
Windows_2 55.35% <ø> (ø)
Windows_3 45.12% <83.33%> (+0.01%) ⬆️
Windows_4 35.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX merged commit 3bead05 into 2.x Apr 5, 2024
93 of 94 checks passed
@ZilongX ZilongX deleted the backport/backport-6348-to-2.x branch April 5, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project seasoned-contributor v2.14.0 version decoupling
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants