-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover-next] dataframes respects datasources #7092
Conversation
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Invalid PrefixInvalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
❌ Invalid PrefixInvalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
1 similar comment
❌ Invalid PrefixInvalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test". |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7092 +/- ##
==========================================
- Coverage 67.45% 67.42% -0.03%
==========================================
Files 3448 3448
Lines 67916 67945 +29
Branches 11042 11052 +10
==========================================
+ Hits 45812 45815 +3
- Misses 19435 19462 +27
+ Partials 2669 2668 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. If this gets accepted follow ups need to happen: * should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state. * some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted * weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected * better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`. Rebase of #7092 Issue: #6957 --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. If this gets accepted follow ups need to happen: * should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state. * some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted * weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected * better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`. Rebase of #7092 Issue: #6957 --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d3d1c43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. If this gets accepted follow ups need to happen: * should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state. * some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted * weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected * better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`. Rebase of #7092 Issue: #6957 --------- (cherry picked from commit d3d1c43) Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Parses user string between
::datasource::
to get the data source Then appends the dataSourceId in the meta.Also creates the data frame before the interceptor to keep the meta info passed around.
If this gets accepted follow ups need to happen:
::
.Issues Related
#6957
Screenshot
Testing the changes
run
yarn opensearch snapshot --sql
run
yarn start:enhancements
add a new data source connection
Changelog
Check List
yarn test:jest
yarn test:jest_integration