-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover-Next] Adding datasources support for dataframes #7106
Conversation
Signed-off-by: Sean Li <lnse@amazon.com>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
1 similar comment
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
@sejli This is temporary right? Can we mark it inthe code and link back to an issue or this PR to indicate that if thats the case |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7106 +/- ##
==========================================
- Coverage 67.45% 67.42% -0.03%
==========================================
Files 3448 3448
Lines 67916 67945 +29
Branches 11042 11052 +10
==========================================
+ Hits 45812 45813 +1
- Misses 19435 19463 +28
Partials 2669 2669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7106-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3d1c43124cc51e0199a70c38874490f0fd6d82a
# Push it to GitHub
git push --set-upstream origin backport/backport-7106-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
I believe so. One thing though it could help to trigger some suggestions based on datasources |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7106-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3d1c43124cc51e0199a70c38874490f0fd6d82a
# Push it to GitHub
git push --set-upstream origin backport/backport-7106-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. If this gets accepted follow ups need to happen: * should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state. * some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted * weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected * better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`. Rebase of #7092 Issue: #6957 --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit d3d1c43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta. Also creates the data frame before the interceptor to keep the meta info passed around. If this gets accepted follow ups need to happen: * should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state. * some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted * weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected * better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`. Rebase of #7092 Issue: #6957 --------- (cherry picked from commit d3d1c43) Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7106-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3d1c43124cc51e0199a70c38874490f0fd6d82a
# Push it to GitHub
git push --set-upstream origin backport/backport-7106-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7106-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3d1c43124cc51e0199a70c38874490f0fd6d82a
# Push it to GitHub
git push --set-upstream origin backport/backport-7106-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Manually backported in #7139 |
Description
Parses user string between
::datasource::
to get the data source Then appends the dataSourceId in the meta.Also creates the data frame before the interceptor to keep the meta info passed around.
If this gets accepted follow ups need to happen:
::
.Rebase of #7092
Issues Resolved
#6957
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration