Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Register workspace settings under setup and settings #7242

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Jul 15, 2024

Description

This PR is for registering workspace settings under setup and settings. The workspace settings will link to the workspace list page. To support display link in the left navigation, need to update link status to visible when nav group enabled.

Issues Resolved

#7244

Screenshot

image

Testing the changes

All changes working fine in the feature/navigation-next branch. Need to checkout the code and rebase feature/navigation-next branch.
Another way is to refer the src/plugins/workspace/public/plugin.test.ts unit test file. All changes have been covered in it.

Changelog

  • feat: [Workspace] Register workspace settings under setup and settings

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (9893ce1) to head (7e28959).
Report is 329 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7242      +/-   ##
==========================================
- Coverage   67.62%   67.61%   -0.02%     
==========================================
  Files        3471     3471              
  Lines       68613    68615       +2     
  Branches    11165    11166       +1     
==========================================
- Hits        46399    46391       -8     
- Misses      19510    19520      +10     
  Partials     2704     2704              
Flag Coverage Δ
Linux_1 33.27% <100.00%> (+<0.01%) ⬆️
Linux_2 55.30% <ø> (ø)
Linux_3 45.26% <ø> (-0.02%) ⬇️
Linux_4 34.69% <ø> (ø)
Windows_1 ?
Windows_2 55.25% <ø> (ø)
Windows_3 45.27% <ø> (ø)
Windows_4 34.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opensearch-changeset-bot bot added a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Jul 15, 2024
@wanglam wanglam force-pushed the feat-register-workspace-list-as-settings branch from 4c72641 to ff3b73a Compare July 15, 2024 07:24
@wanglam wanglam changed the base branch from main to feature/navigation-next July 15, 2024 07:24
opensearch-changeset-bot bot added a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Jul 15, 2024
opensearch-changeset-bot bot added a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Jul 15, 2024
@wanglam wanglam changed the title [Workspace]Move workspace list under setup and settings nav group [Workspace]Register workspace settings under setup and settings Jul 15, 2024
@wanglam wanglam closed this Jul 15, 2024
@wanglam wanglam force-pushed the feat-register-workspace-list-as-settings branch from 1c76921 to c3dd768 Compare July 15, 2024 08:37
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam reopened this Jul 15, 2024
@wanglam wanglam changed the base branch from feature/navigation-next to main July 15, 2024 09:10
@wanglam wanglam marked this pull request as ready for review July 15, 2024 09:50
// nav link should be visible when nav group enabled
navLinkStatus: core.chrome.navGroup.getNavGroupEnabled()
? AppNavLinkStatus.visible
: AppNavLinkStatus.hidden,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment of when core.chrome.navGroup.getNavGroupEnabled() changed, the page will refresh and application setup will execute it again?

@SuZhou-Joe SuZhou-Joe merged commit dcd4cf6 into opensearch-project:main Jul 16, 2024
75 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 16, 2024
* Move workspace list under setup and settings nav group

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #7242 created/updated

* Add comment for page refresh

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dcd4cf6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 16, 2024
… (#7258)

* Move workspace list under setup and settings nav group



* Changeset file for PR #7242 created/updated

* Add comment for page refresh



---------



(cherry picked from commit dcd4cf6)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants