Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]Register workspace settings under setup and settings #7258

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport dcd4cf6 from #7242.

* Move workspace list under setup and settings nav group

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #7242 created/updated

* Add comment for page refresh

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dcd4cf6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (6e5ee91) to head (b272445).

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7258      +/-   ##
==========================================
- Coverage   67.66%   67.66%   -0.01%     
==========================================
  Files        3450     3450              
  Lines       68149    68151       +2     
  Branches    11069    11070       +1     
==========================================
  Hits        46112    46112              
- Misses      19362    19363       +1     
- Partials     2675     2676       +1     
Flag Coverage Δ
Linux_1 33.15% <100.00%> (+<0.01%) ⬆️
Linux_2 55.38% <ø> (ø)
Linux_3 45.09% <ø> (+0.01%) ⬆️
Linux_4 34.88% <ø> (ø)
Windows_1 33.18% <100.00%> (+<0.01%) ⬆️
Windows_2 55.34% <ø> (ø)
Windows_3 ?
Windows_4 34.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit f0b3474 into 2.x Jul 16, 2024
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants