Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7436

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 24, 2024

Backport 3f78c94 from #7401.

Changelog

  • skip

…t and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.14%. Comparing base (f872b02) to head (93d9720).

Files Patch % Lines
...ic/react_router_navigate/react_router_navigate.tsx 60.00% 1 Missing and 1 partial ⚠️
src/plugins/workspace/public/plugin.ts 0.00% 1 Missing and 1 partial ⚠️
src/core/public/chrome/ui/header/header.tsx 80.00% 1 Missing ⚠️
src/plugins/advanced_settings/public/plugin.ts 0.00% 1 Missing ⚠️
...rc/plugins/data_source_management/public/plugin.ts 66.66% 1 Missing ⚠️
.../plugins/index_pattern_management/public/plugin.ts 0.00% 1 Missing ⚠️
.../plugins/saved_objects_management/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7436   +/-   ##
=======================================
  Coverage   64.13%   64.14%           
=======================================
  Files        3614     3614           
  Lines       78680    78690   +10     
  Branches    12432    12436    +4     
=======================================
+ Hits        50463    50477   +14     
+ Misses      25167    25161    -6     
- Partials     3050     3052    +2     
Flag Coverage Δ
Linux_1 30.90% <6.25%> (-0.01%) ⬇️
Linux_2 55.59% <87.50%> (+<0.01%) ⬆️
Linux_3 40.63% <15.78%> (-0.02%) ⬇️
Linux_4 31.77% <15.78%> (+<0.01%) ⬆️
Windows_1 30.94% <6.25%> (+0.01%) ⬆️
Windows_2 55.54% <87.50%> (+<0.01%) ⬆️
Windows_3 40.64% <15.78%> (-0.01%) ⬇️
Windows_4 31.77% <15.78%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe changed the title [Backport main] [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. Jul 24, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 24, 2024
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 24, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 24, 2024
ruanyl
ruanyl previously approved these changes Jul 24, 2024
@ruanyl ruanyl dismissed their stale review July 24, 2024 09:09

still checking

@SuZhou-Joe SuZhou-Joe merged commit c2577f2 into main Jul 24, 2024
75 of 79 checks passed
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…t and other similar cases. (opensearch-project#7401) (opensearch-project#7436)

* feat: add scoped breadcrumbs



* Changeset file for PR opensearch-project#7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR opensearch-project#7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports bug Something isn't working distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants