Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7401

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Jul 23, 2024

Description

This PR fixes the issue that breadcrumbs do not function correctly in the new application when navigation feature flag is turned on.

When new navigation is turned on, we add 4 new applications: assets / index pattern management / data sources management / application settings to left navigation.

They used to work as sub applications within Dashboard management because the parent application adds intercept on the setBreadCrumbs to make the breadcrumb comply with the BrowserRouter and inherit the parent history from OSD core.

While after migrated to standard application in left navigation, these 4 applications are using core.chrome.setBreadCrumbs to update the breadCrumb, which do not have support BrowserRouter.

The change will only take effect when feature flag enabled, it won't have any impact on the existing application.

  • Resolve the breadcrumb issue
  • Make left navigation expandable in home page when workspace is enabled
  • Make workspace overview visible in all use case

Issues Resolved

Screenshot

Before the fix

20240723175723455.mp4

After the fix

20240723175850857.mp4

Testing the changes

Changelog

  • fix: make breadcrumb of 4 new added applications comply with BrowserRouter.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe changed the title [navigation-next]fix: use scoped breadcrumbs [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. Jul 23, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 23, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 23, 2024
@SuZhou-Joe SuZhou-Joe added the bug Something isn't working label Jul 23, 2024
@opensearch-changeset-bot opensearch-changeset-bot bot dismissed stale reviews from ruanyl and ZilongX via 8803144 July 24, 2024 01:58
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe changed the base branch from main to feature/navigation-next July 24, 2024 07:52
@SuZhou-Joe SuZhou-Joe merged commit 3f78c94 into opensearch-project:feature/navigation-next Jul 24, 2024
68 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7401-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f78c94e640209027d9e7cc5cd349403f70dea18
# Push it to GitHub
git push --set-upstream origin backport/backport-7401-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7401-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7401-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f78c94e640209027d9e7cc5cd349403f70dea18
# Push it to GitHub
git push --set-upstream origin backport/backport-7401-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7401-to-2.16.

SuZhou-Joe added a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…t and other similar cases. (opensearch-project#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
SuZhou-Joe added a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 24, 2024
…t and other similar cases. (#7401) (#7436)

* feat: add scoped breadcrumbs



* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…t and other similar cases. (opensearch-project#7401) (opensearch-project#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 25, 2024
…t and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
…t and other similar cases. (opensearch-project#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR opensearch-project#7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
SuZhou-Joe added a commit that referenced this pull request Jul 25, 2024
…ource management and other similar cases. (#7438)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: functional test error

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change the order of createRef

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat:  revert useless change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
LDrago27 added a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <menwe@amazon.com>

* SQL keyword suggestion

Signed-off-by: Eric <menwe@amazon.com>

* column and values suggestions

Signed-off-by: Eric <menwe@amazon.com>

* adjust values suggestions and ignored token

Signed-off-by: Eric <menwe@amazon.com>

* suggestion type casting

Signed-off-by: Eric <menwe@amazon.com>

* ignore functions

Signed-off-by: Eric <menwe@amazon.com>

* case insensitive

Signed-off-by: Eric <menwe@amazon.com>

* change to use grammar for insensitive case

Signed-off-by: Eric <menwe@amazon.com>

* fix multi-line issue

Signed-off-by: Eric <menwe@amazon.com>

* code cleanup

Signed-off-by: Eric <menwe@amazon.com>

* move ppl out of scope

Signed-off-by: Eric <menwe@amazon.com>

* rename folder and add ignoring rules

Signed-off-by: Eric <menwe@amazon.com>

* resolve type issue

Signed-off-by: Eric <menwe@amazon.com>

* fix ppl suggestion provider issue

Signed-off-by: Eric <menwe@amazon.com>

* remove function suggestion

Signed-off-by: Eric <menwe@amazon.com>

* some code clean up and adding tests

Signed-off-by: Eric <menwe@amazon.com>

* cursor tests

Signed-off-by: Eric <menwe@amazon.com>

* remove testing setup

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* update yarn file

Signed-off-by: Eric <menwe@amazon.com>

* add missing testing library

Signed-off-by: Eric <menwe@amazon.com>

* MDS integration

Signed-off-by: Eric <menwe@amazon.com>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <menwe@amazon.com>

* column suggest for agg function

Signed-off-by: Eric <menwe@amazon.com>

* revert version

Signed-off-by: Eric <menwe@amazon.com>

* opensearch sql syntax highlighting

Signed-off-by: Eric <menwe@amazon.com>

* add utility tests

Signed-off-by: Eric <menwe@amazon.com>

* symbol table test

Signed-off-by: Eric <menwe@amazon.com>

* error listener test

Signed-off-by: Eric <menwe@amazon.com>

* parse test

Signed-off-by: Eric <menwe@amazon.com>

* add suggestion provider to single line query editor

Signed-off-by: Eric <menwe@amazon.com>

* remove one test

Signed-off-by: Eric <menwe@amazon.com>

* add connection service type

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix typo

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick

Signed-off-by: Eric <menwe@amazon.com>

* SQL keyword suggestion

Signed-off-by: Eric <menwe@amazon.com>

* column and values suggestions

Signed-off-by: Eric <menwe@amazon.com>

* adjust values suggestions and ignored token

Signed-off-by: Eric <menwe@amazon.com>

* suggestion type casting

Signed-off-by: Eric <menwe@amazon.com>

* ignore functions

Signed-off-by: Eric <menwe@amazon.com>

* case insensitive

Signed-off-by: Eric <menwe@amazon.com>

* change to use grammar for insensitive case

Signed-off-by: Eric <menwe@amazon.com>

* fix multi-line issue

Signed-off-by: Eric <menwe@amazon.com>

* code cleanup

Signed-off-by: Eric <menwe@amazon.com>

* move ppl out of scope

Signed-off-by: Eric <menwe@amazon.com>

* rename folder and add ignoring rules

Signed-off-by: Eric <menwe@amazon.com>

* resolve type issue

Signed-off-by: Eric <menwe@amazon.com>

* fix ppl suggestion provider issue

Signed-off-by: Eric <menwe@amazon.com>

* remove function suggestion

Signed-off-by: Eric <menwe@amazon.com>

* some code clean up and adding tests

Signed-off-by: Eric <menwe@amazon.com>

* cursor tests

Signed-off-by: Eric <menwe@amazon.com>

* remove testing setup

Signed-off-by: Eric <menwe@amazon.com>

* add changelog

Signed-off-by: Eric <menwe@amazon.com>

* update yarn file

Signed-off-by: Eric <menwe@amazon.com>

* add missing testing library

Signed-off-by: Eric <menwe@amazon.com>

* MDS integration

Signed-off-by: Eric <menwe@amazon.com>

* minor interface change and disable word based suggestion

Signed-off-by: Eric <menwe@amazon.com>

* update ID_LITERAL and recompile grammar

Signed-off-by: Eric <menwe@amazon.com>

* column suggest for agg function

Signed-off-by: Eric <menwe@amazon.com>

* revert version

Signed-off-by: Eric <menwe@amazon.com>

* opensearch sql syntax highlighting

Signed-off-by: Eric <menwe@amazon.com>

* add utility tests

Signed-off-by: Eric <menwe@amazon.com>

* symbol table test

Signed-off-by: Eric <menwe@amazon.com>

* error listener test

Signed-off-by: Eric <menwe@amazon.com>

* parse test

Signed-off-by: Eric <menwe@amazon.com>

* add suggestion provider to single line query editor

Signed-off-by: Eric <menwe@amazon.com>

* remove one test

Signed-off-by: Eric <menwe@amazon.com>

* add connection service type

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7440 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* aggs not working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* almost there

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* stablish

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* thanks ashwin

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ref name

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix timefields

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* clean up some console logs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* go safer route of setting language

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* its working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix names

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* restore code editor and indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* sql df

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix external datasources again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change from nested ternary to if else

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix typo

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7435 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------

Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
(cherry picked from commit 0515fb2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this pull request Jul 25, 2024
* Bump OUI to 1.8.0 (#7363)


(cherry picked from commit c1bae75)

* [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336)

* cherry pick



* SQL keyword suggestion



* column and values suggestions



* adjust values suggestions and ignored token



* suggestion type casting



* ignore functions



* case insensitive



* change to use grammar for insensitive case



* fix multi-line issue



* code cleanup



* move ppl out of scope



* rename folder and add ignoring rules



* resolve type issue



* fix ppl suggestion provider issue



* remove function suggestion



* some code clean up and adding tests



* cursor tests



* remove testing setup



* add changelog



* update yarn file



* add missing testing library



* MDS integration



* minor interface change and disable word based suggestion



* update ID_LITERAL and recompile grammar



* column suggest for agg function



* revert version



* opensearch sql syntax highlighting



* add utility tests



* symbol table test



* error listener test



* parse test



* add suggestion provider to single line query editor



* remove one test



* add connection service type



---------


(cherry picked from commit 9348bd4)

* Move TopNavLinks to new Nav Bar Discover (#7326)

This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.


(cherry picked from commit e46e54a)

* [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401)

* feat: add scoped breadcrumbs



* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

* [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440)

* Move data source manageable feature flag to DSM plugin



* Changeset file for PR #7440 created/updated

---------



(cherry picked from commit dfcd2e1)

* [Discover-next] data set picker (#7426)

* update using query manager



* aggs not working



* almost there



* stablish



* thanks ashwin



* update ref name



* fix timefields



* clean up some console logs



* go safer route of setting language



* its working again



* fix names



* restore code editor and indices



* sql df



* fix external datasources again



---------


(cherry picked from commit 6a079d3)

* Fix add filter for numeric scripted field (#7022)

* Fix add filter for scripted field



* add unit test



* change from nested ternary to if else



* add more unit tests



* change unit tests



* fix typo



---------


(cherry picked from commit 7c1f8fc)

* [Bug][Workspace] Add permission validation at workspace detail page (#7435)

* [Bug][Workspace] Add permission validate at workspace detail page



* Changeset file for PR #7435 created/updated

---------



(cherry picked from commit 45d34b5)

* Revert "[Discover-next] data set picker (#7426)" (#7479)

This reverts commit 6a079d3.

---------








(cherry picked from commit 0515fb2)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Eric Wei <menwe@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: yuboluo <yubonluo@amazon.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
…t and other similar cases. (opensearch-project#7401) (opensearch-project#7436)

* feat: add scoped breadcrumbs



* Changeset file for PR opensearch-project#7401 created/updated

* feat: move data source management register logic up a little bit



* feat: add unit test



* feat: revert the home related change



* fix: overview error in all use case when workspace is enabled



* fix: update snapshot



* Changeset file for PR opensearch-project#7401 created/updated

* fix: hide nav groups that should be displayed



* feat: hide expand icon in left navigation



* feat: update



---------




(cherry picked from commit 3f78c94)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants